From: Eli Zaretskii <eliz@gnu.org>
To: braungb88@gmail.com
Cc: 70122@debbugs.gnu.org
Subject: bug#70122: 29.3.50; transpose-regions can crash Emacs
Date: Mon, 01 Apr 2024 16:17:04 +0300 [thread overview]
Message-ID: <86ttkl9q9b.fsf@gnu.org> (raw)
In-Reply-To: <86wmph9u1i.fsf@gnu.org> (message from Eli Zaretskii on Mon, 01 Apr 2024 14:55:21 +0300)
> Cc: 70122@debbugs.gnu.org
> Date: Mon, 01 Apr 2024 14:55:21 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> > Please find attached a patch to transpose-regions
> > with added tests. (The patch intends to fix typos:
> > makes sure lengths in bytes and characters are not confused.
>
> Thanks, but could you please show the minimal change required to fix
> just the particular problem with this scenario (and perhaps explain
> the reason for the crash in words), without any cleanup and
> typo/confusion fixes? That would make it easier to review the patch,
> whereas with what you sent, it is hard to understand what exactly is
> being fixed.
I came up with the patch below. The problem is that len_mid, which is
a difference between byte positions, was sometimes used in calls that
expect differences between character positions instead. The patch
below passes both your test and the already-existing tests in
test/src/editfns-tests.el. WDYT?
> > One case (likely for optimization only) has been removed,
> > seemed too much trouble to get it right.)
>
> If you explain the reason for the crash, perhaps we could leave the
> optimization alone.
I found that len_mid was not used in that branch, so we can leave it
alone.
Here's the patch:
diff --git a/src/editfns.c b/src/editfns.c
index 4ccf765..124fd47 100644
--- a/src/editfns.c
+++ b/src/editfns.c
@@ -4677,7 +4677,8 @@ DEFUN ("transpose-regions", Ftranspose_regions, Stranspose_regions, 4, 5,
modify_text (start1, end2);
record_change (start1, (end2 - start1));
tmp_interval1 = copy_intervals (cur_intv, start1, len1);
- tmp_interval_mid = copy_intervals (cur_intv, end1, len_mid);
+ tmp_interval_mid = copy_intervals (cur_intv, end1,
+ start2 - (start1 + len1));
tmp_interval2 = copy_intervals (cur_intv, start2, len2);
tmp_interval3 = validate_interval_range (buf, &startr1, &endr2, 0);
@@ -4697,7 +4698,8 @@ DEFUN ("transpose-regions", Ftranspose_regions, Stranspose_regions, 4, 5,
graft_intervals_into_buffer (tmp_interval1, end2 - len1,
len1, current_buffer, 0);
graft_intervals_into_buffer (tmp_interval_mid, start1 + len2,
- len_mid, current_buffer, 0);
+ start2 - (start1 + len1),
+ current_buffer, 0);
graft_intervals_into_buffer (tmp_interval2, start1,
len2, current_buffer, 0);
}
@@ -4710,7 +4712,8 @@ DEFUN ("transpose-regions", Ftranspose_regions, Stranspose_regions, 4, 5,
modify_text (start1, end2);
tmp_interval1 = copy_intervals (cur_intv, start1, len1);
- tmp_interval_mid = copy_intervals (cur_intv, end1, len_mid);
+ tmp_interval_mid = copy_intervals (cur_intv, end1,
+ start2 - (start1 + len1));
tmp_interval2 = copy_intervals (cur_intv, start2, len2);
tmp_interval3 = validate_interval_range (buf, &startr1, &endr2, 0);
@@ -4730,7 +4733,8 @@ DEFUN ("transpose-regions", Ftranspose_regions, Stranspose_regions, 4, 5,
graft_intervals_into_buffer (tmp_interval1, end2 - len1,
len1, current_buffer, 0);
graft_intervals_into_buffer (tmp_interval_mid, start1 + len2,
- len_mid, current_buffer, 0);
+ start2 - (start1 + len1),
+ current_buffer, 0);
graft_intervals_into_buffer (tmp_interval2, start1,
len2, current_buffer, 0);
}
next prev parent reply other threads:[~2024-04-01 13:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 10:02 bug#70122: 29.3.50; transpose-regions can crash Emacs Braun Gábor
2024-04-01 11:55 ` Eli Zaretskii
2024-04-01 13:17 ` Eli Zaretskii [this message]
2024-04-03 18:52 ` Braun Gábor
2024-04-04 4:48 ` Eli Zaretskii
2024-04-12 9:39 ` Braun Gábor
2024-04-12 9:42 ` Braun Gábor
2024-04-13 10:34 ` Eli Zaretskii
2024-04-16 14:26 ` Braun Gábor
2024-04-20 7:50 ` Eli Zaretskii
2024-04-24 12:35 ` Braun Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ttkl9q9b.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=70122@debbugs.gnu.org \
--cc=braungb88@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.