From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68929: [PATCH] Copy which-key from GNU ELPA into core Date: Mon, 15 Apr 2024 14:13:30 +0300 Message-ID: <86ttk2lvz9.fsf@gnu.org> References: <871q9rvqbi.fsf@jeremybryant.net> <87mssc65y8.fsf@posteo.net> <87y1bwrll4.fsf@jeremybryant.net> <86h6ijxzjk.fsf@gnu.org> <87msrh4kkc.fsf@jeremybryant.net> <87jzml3rlz.fsf@posteo.net> <87wmp2ibjj.fsf@jeremybryant.net> <871q78i9kb.fsf@jeremybryant.net> <86y19gmevj.fsf@gnu.org> <87plurzk6v.fsf@jeremybryant.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2222"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, 68929@debbugs.gnu.org, monnier@iro.umontreal.ca, justin@burkett.cc To: Jeremy Bryant Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 15 13:15:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rwKIs-0000Kb-No for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Apr 2024 13:15:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rwKIg-0003sW-FP; Mon, 15 Apr 2024 07:15:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwKIe-0003rq-Qw for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2024 07:15:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rwKIe-00005J-I9 for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2024 07:15:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rwKIp-0000aF-Ks for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2024 07:15:11 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Apr 2024 11:15:10 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68929 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68929-submit@debbugs.gnu.org id=B68929.17131796591883 (code B ref 68929); Mon, 15 Apr 2024 11:15:10 +0000 Original-Received: (at 68929) by debbugs.gnu.org; 15 Apr 2024 11:14:19 +0000 Original-Received: from localhost ([127.0.0.1]:36955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwKHq-0000TV-Qp for submit@debbugs.gnu.org; Mon, 15 Apr 2024 07:14:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwKHf-0000Rg-S7 for 68929@debbugs.gnu.org; Mon, 15 Apr 2024 07:14:07 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwKHN-000851-Hp; Mon, 15 Apr 2024 07:13:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=eGNhZ6XmxVdtXbE8OuGaTfFsfazFCh0IE+Ya6h/ANpU=; b=Bglkf16wLv4U QVbc6lFrlRaqOxrMp373xYWjey6hhf04U+6ss6OQYawFsnSSvbXIXZg7aEAebaWvYTs324/IF3Aqh oYUxD2ybCwDHxh+XkQh1dV16b0QlpePK7XJhU7jxRh66IWdiEGS1tIElkBcZhZ5NDAYJLq/YoJ0lG gG+wP+xNnnHHXTVemyIpM1LUE/6QxStq2Bb/Q2AAy7pjG3658pzOzBbdomACqzAWHPQfllHqGoyY3 cLZyu5m7uwtNzJuFq+dFn511/A4kzAGjLWf/YVfjjSwCYpDM14gCIT99tq4F5CWQ5G88AiM8LDl04 h226gIUD1phWhNLSZrs0CA==; In-Reply-To: <87plurzk6v.fsf@jeremybryant.net> (message from Jeremy Bryant on Sun, 14 Apr 2024 22:52:08 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283355 Archived-At: > From: Jeremy Bryant > Cc: philipk@posteo.net, 68929@debbugs.gnu.org, monnier@iro.umontreal.ca, > justin@burkett.cc > Date: Sun, 14 Apr 2024 22:52:08 +0100 > > > Is line length the only issue you are looking at? What about other > > requirements of our logs and ChangeLog files, including those imposed > > by authors.el? The most problematic issue is when the file names > > and/or its leading directories in the log message don't fit the actual > > place and name of the file in the tree. Did you look at those issues? > > They typically come up when preparing a release tarball, and are quite > > annoying at that time, especially if there are a lot of them, because > > they require manual fixes. > > Yes, sorry, I have only looked at the line length because it came up as > a blocker. > > As far as the file names, this appears stable, but the place in the tree > would move as part of this proposed integration, to be in > lisp/which-key.el rather than at the root as is the case for the ELPA > version. Is this a problem and how was it resolved with other moves > from ELPA to core? Sorry, I don't remember the details. I probably fixed some issues by hand, and for some others added/modified the relevant data structures in admin/authors.el, which see. > Upon inspection, the earlier historical commits do not generally conform to the > Changelog format. > How to investigate any issues for authors.el? Is there a function try > and run? The function is "M-x authors", defined in admin/authors.el. It first updates ChangeLog.4, and then attempts the regenerate AUTHORS; you will need to "git reset" to return to the current versions once you are finished. The following extract from admin/make-tarball.txt gives some guidance, and more information is available in comments to authors.el: After "M-x authors" finishes, if there is an "*Authors Errors*" buffer, address the issues. If there was a ChangeLog typo, fix the relevant entry. If a file was deleted or renamed, consider adding an appropriate entry to variables authors-ignored-files, authors-valid-file-names, or authors-renamed-files-alist in authors.el. If some authors are "ignored", consider adding entries to the author-aliases variable. If necessary, repeat 'C-u M-x authors' after making those changes. If you see too many problems than you can handle, feel free to give up on them and leave them until the first pretest.