From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 70426@debbugs.gnu.org, michael.albinus@gmx.de
Subject: bug#70426: 30.0.50; lisp-tests fail
Date: Wed, 17 Apr 2024 15:41:34 +0300 [thread overview]
Message-ID: <86ttk0go01.fsf@gnu.org> (raw)
In-Reply-To: <861q74bhuu.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 17 Apr 2024 09:53:13 +0300)
> From: Juri Linkov <juri@linkov.net>
> Cc: Michael Albinus <michael.albinus@gmx.de>, 70426@debbugs.gnu.org
> Date: Wed, 17 Apr 2024 09:53:13 +0300
>
> close 70426 30.0.50
> quit
>
> >> # make -C test lisp-tests
> >> 2 unexpected results:
> >> FAILED up-list-cross-string
> >> FAILED up-list-out-of-string
> >
> > Juri, this is due to your changes in
> >
> > commit 568c1741352a4932508fbbd474b9fd9ebe90ddfb
> > Author: Juri Linkov <juri@linkov.net>
> > AuthorDate: Sun Apr 14 19:18:31 2024 +0300
> > Commit: Juri Linkov <juri@linkov.net>
> > CommitDate: Sun Apr 14 19:22:01 2024 +0300
> >
> > Add 'forward-sexp-default-function' to be used by 'treesit-forward-sexp'
> >
> > * lisp/emacs-lisp/lisp.el (forward-sexp-default-function):
> > New function with body from 'forward-sexp' (bug#68993).
> > (forward-sexp-function): Change the default value from nil to
> > 'forward-sexp-default-function'.
> > (forward-sexp): Use either 'forward-sexp-function' or
> > 'forward-sexp-default-function'.
> >
> > * lisp/treesit.el (treesit-forward-sexp): In nodes of type 'text'
> > fall back to 'forward-sexp-default-function'. Improve docstring.
> >
> > * doc/lispref/positions.texi (List Motion): Fix pxref.
> >
> > Could you please look into this?
>
> This is because 'up-list' contains:
>
> (if (null forward-sexp-function)
>
> This means that can't do the right thing anymore
> to set the default function to 'forward-sexp-function'.
>
> Ok, so now reverted it back to nil.
Thanks, the test now passes for me. Michael, if it passes for you as
well, please close the bug.
next prev parent reply other threads:[~2024-04-17 12:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 16:30 bug#70426: 30.0.50; lisp-tests fail Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-16 16:47 ` Eli Zaretskii
2024-04-17 6:53 ` Juri Linkov
2024-04-17 12:41 ` Eli Zaretskii [this message]
2024-04-17 13:14 ` Eli Zaretskii
2024-04-17 16:14 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ttk0go01.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=70426@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.