From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.comp.lib.gnulib.bugs,gmane.emacs.devel Subject: Gnulib's boot-time.c breaks the build with mingw.org's MinGW Date: Tue, 04 Jun 2024 19:27:23 +0300 Message-ID: <86tti8k710.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24222"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Collin Funk , emacs-devel@gnu.org, bug-gnulib@gnu.org To: Paul Eggert , Bruno Haible Original-X-From: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane-mx.org@gnu.org Tue Jun 04 18:27:37 2024 Return-path: Envelope-to: gnu-bug-gnulib@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sEX0b-00069H-NL for gnu-bug-gnulib@m.gmane-mx.org; Tue, 04 Jun 2024 18:27:37 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sEX0T-0007P8-Op; Tue, 04 Jun 2024 12:27:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEX0S-0007OP-9r; Tue, 04 Jun 2024 12:27:28 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEX0Q-0005as-MC; Tue, 04 Jun 2024 12:27:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to: references; bh=S2d770mzyIYmKFUr8GjC6l415hd+efm629lsU2KDVK8=; b=BOxJ42H29iTFu6 Dq0lP5/jDGzWFAnEdU2CrgRZZjI9tD3LzULZL7NXNFJ2GEzKQi5JLCnA72QXgQdTUam+NT0g2LxBb 65LYTWgv7+Y/p9sINoLSvnLxLpjiZou9samtMQFOQZvwQ/CKPubUWaAyIrSFtfWVddAM/3PONw8x+ eqAMHVqwp6/eWAnE/giLaaVlBGRnLjP8w71fFVbzsg66UJIYwTfPPhJKg/sreKrYPLs6KWahBVbQq SWp9kaKDdlyUTNd+cgLkXjNsKjVu3YYRZO//K6M3k39gi2J2Qq6H7/7f5fPOVqUz2cRtRGdEzPXbL cFbVf7nQtAvm+Ot2Z1hQ==; X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane-mx.org@gnu.org Original-Sender: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.comp.lib.gnulib.bugs:50698 gmane.emacs.devel:319821 Archived-At: Paul imported today the latest changes from Gnulib, and that broke the Emacs MinGW build on the master branch when mingw.org's MinGW is used: boot-time.c:49:11: fatal error: sysinfoapi.h: No such file or directory 49 | # include | ^~~~~~~~~~~~~~ compilation terminated. mingw.org's MinGW doesn't have the sysinfoapi.h header (unlike MinGW64). However, that header is not really needed here because the signature of the GetTickCount64 function, which boot-time-aux.h now calls, is completely defined in boot-time-aux.h: typedef ULONGLONG (WINAPI * GetTickCount64FuncType) (void); Moreover, the Microsoft documentation, here: https://learn.microsoft.com/en-us/windows/win32/api/sysinfoapi/nf-sysinfoapi-gettickcount64 clearly says that the header file to be included when using GetTickCount64 is windows.h, not sysinfoapi.h directly. So I think the Gnulib code should be amended not to include sysinfoapi.h. For the time being I made a local change in Emacs, to be able to build the master branch with MinGW, but I don't think it's an Emacs-specific issue. P.S. Paul, please from now on, and until the emacs-30 release branch is cut, please coordinate with me any updates from Gnulib. I don't want us to destabilize the master branch inadvertently so close to the beginning of the release cycle. TIA.