From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Shell quoting in Eshell (was: eshell-batch-file)
Date: Sun, 16 Jun 2024 08:21:02 +0300 [thread overview]
Message-ID: <86tthtsbsx.fsf@gnu.org> (raw)
In-Reply-To: <bdf43787-b0d7-0d4b-573f-7c336708ddb5@gmail.com> (message from Jim Porter on Sat, 15 Jun 2024 13:06:53 -0700)
> Date: Sat, 15 Jun 2024 13:06:53 -0700
> Cc: emacs-devel@gnu.org
> From: Jim Porter <jporterbugs@gmail.com>
>
> On 6/15/2024 12:10 PM, Eli Zaretskii wrote:
> > Test esh-cmd-test/which/plain/external-program condition:
> [snip]
> > :value nil :explanation
> > (nonequal-result (command "which sh")
> > (result #("D:/usr/MSYS/bin/sh.exe\n" 22 23 ...))
> > (expected "d:/usr/MSYS/bin/sh.exe\n"))))
> > FAILED 59/66 esh-cmd-test/which/plain/external-program (0.003953 sec) at lisp/eshell/esh-cmd-tests.el:538
> >
> > IOW: you run "which SOMETHING" and pretend to know how it will
> > capitalize the drive letter.
>
> Ah ha! If that's the only failure, then I think this would work? (If
> there are other failures, then I could add a PREDICATE argument to
> 'eshell-command-result-equal' and use that in the necessary places.)
It works with that change, yes. But please add a comment there
explaining why this is done. Since the fix targets a single command,
it can be described in more detail.
Thanks.
next prev parent reply other threads:[~2024-06-16 5:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-09 6:11 eshell-batch-file Eli Zaretskii
2024-06-09 18:55 ` eshell-batch-file Jim Porter
2024-06-09 19:06 ` eshell-batch-file Eli Zaretskii
2024-06-09 19:15 ` Shell quoting in Eshell (was: eshell-batch-file) Eli Zaretskii
2024-06-09 20:07 ` Jim Porter
2024-06-09 22:37 ` Jim Porter
2024-06-15 9:38 ` Eli Zaretskii
2024-06-15 18:36 ` Jim Porter
2024-06-15 19:10 ` Eli Zaretskii
2024-06-15 20:06 ` Jim Porter
2024-06-16 5:21 ` Eli Zaretskii [this message]
2024-06-16 5:57 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86tthtsbsx.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.