From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#71466: 30.0.50; Buffer-menu-group-by non-nil resets point when Buffer List is reverted Date: Thu, 20 Jun 2024 19:38:58 +0300 Organization: LINKOV.NET Message-ID: <86tthnzp19.fsf@mail.linkov.net> References: <86tthzwgsw.fsf@mail.linkov.net> <86msnkyt7c.fsf@mail.linkov.net> <30404984-e7ac-4f92-a194-06438dbf2d03@gutov.dev> <867cemquey.fsf@gnu.org> <864j9qqpfx.fsf@gnu.org> <86tthqp2zc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27488"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Eli Zaretskii , 71466@debbugs.gnu.org, me@eshelyaron.com To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 20 18:43:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sKKsX-0006uA-6x for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Jun 2024 18:43:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sKKsH-000744-B1; Thu, 20 Jun 2024 12:43:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKKsF-00073j-UZ for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2024 12:42:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sKKsE-0006I1-Ov for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2024 12:42:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sKKsI-0007O0-G6 for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2024 12:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jun 2024 16:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71466 X-GNU-PR-Package: emacs Original-Received: via spool by 71466-submit@debbugs.gnu.org id=B71466.171890177528363 (code B ref 71466); Thu, 20 Jun 2024 16:43:02 +0000 Original-Received: (at 71466) by debbugs.gnu.org; 20 Jun 2024 16:42:55 +0000 Original-Received: from localhost ([127.0.0.1]:35983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKKsB-0007NO-Jk for submit@debbugs.gnu.org; Thu, 20 Jun 2024 12:42:55 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:44967) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKKs9-0007N7-Dn for 71466@debbugs.gnu.org; Thu, 20 Jun 2024 12:42:53 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id C33F0FF80A; Thu, 20 Jun 2024 16:42:20 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Tue, 18 Jun 2024 20:47:52 +0300") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287576 Archived-At: >>> And it makes sense to provide this feature to the users of >>> xref-revert-buffer, so I don't see why not. >> All things being equal, leaving the old names of the functions and >> commands should be preferred. That's all I'm saying. It's a minor >> issue, but the cost of staying more compatible is also minor. > > It might be important for the case when somebody has rebound 'g' in Xref > buffers to some other letter - then they reference xref-revert-buffer by > name in their init script. > > Having them end up with a subpar version of it (and perhaps not notice it > either) feels like an unfortunate outcome. So what is the decision? Maybe better to keep xref-revert-buffer as a wrapper around the new function xref--revert-buffer? (defun xref-revert-buffer () (let (restore-functions) (when (boundp 'revert-buffer-restore-functions) (run-hook-wrapped 'revert-buffer-restore-functions (lambda (f) (push (funcall f) restore-functions) nil))) (prog1 (xref--revert-buffer) (mapc #'funcall (delq nil restore-functions)))))