From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71466: 30.0.50; Buffer-menu-group-by non-nil resets point when Buffer List is reverted Date: Tue, 25 Jun 2024 15:54:40 +0300 Message-ID: <86tthh9o8f.fsf@gnu.org> References: <86tthzwgsw.fsf@mail.linkov.net> <86msnkyt7c.fsf@mail.linkov.net> <30404984-e7ac-4f92-a194-06438dbf2d03@gutov.dev> <867cemquey.fsf@gnu.org> <864j9qqpfx.fsf@gnu.org> <86tthqp2zc.fsf@gnu.org> <86tthnzp19.fsf@mail.linkov.net> <10881a4d-5b44-4b7e-9686-d6f7bf3ddace@gutov.dev> <86r0cmg9wf.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20164"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71466@debbugs.gnu.org, me@eshelyaron.com, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 25 14:55:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sM5hh-00050S-H5 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Jun 2024 14:55:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sM5hP-0003HT-52; Tue, 25 Jun 2024 08:55:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sM5hN-0003H3-07 for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2024 08:55:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sM5hM-0004fF-OH for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2024 08:55:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sM5hO-0005av-Bc for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2024 08:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2024 12:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71466 X-GNU-PR-Package: emacs Original-Received: via spool by 71466-submit@debbugs.gnu.org id=B71466.171932009421481 (code B ref 71466); Tue, 25 Jun 2024 12:55:02 +0000 Original-Received: (at 71466) by debbugs.gnu.org; 25 Jun 2024 12:54:54 +0000 Original-Received: from localhost ([127.0.0.1]:36453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sM5hG-0005aP-Ch for submit@debbugs.gnu.org; Tue, 25 Jun 2024 08:54:54 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sM5hD-0005a8-VK for 71466@debbugs.gnu.org; Tue, 25 Jun 2024 08:54:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sM5h6-0004cL-3w; Tue, 25 Jun 2024 08:54:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=q1alD8Cd0uH28mN2mxJiYa+YGKwgIAJ/ZI20opiEVy4=; b=DmJRKL3pmPjr X8DY6iDnfRW34ARtmpUgwZBOCB/xP7Sk/yqKm+yrUkBwbKYOnmK7L/ZLUjp/pldsQwBkXigB9w2Zt tHMkO9KRVskjCb2tj/hRGWgdYedte5J+SOCuwKERSlI31WePpTEgLh8YVG5ocCC1PUcC9yedCajKX NpaGjU60VRq5zYnZxHnfMhXgsWvkgJd2WwUxJPk3hhwrZgj+YlBME6oM8e6NhMeHFn93VcGZ0j2NS jmI3aX53tE9dcxnAdYOaq1qMl8if0S4BKX3BIFv+las6XwoFRZ/6z1atL197IhBTZiUOr3tRlrdsz X3JDndL4QFUUZYycbxD+LA==; In-Reply-To: (message from Dmitry Gutov on Tue, 25 Jun 2024 01:42:46 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287885 Archived-At: > Date: Tue, 25 Jun 2024 01:42:46 +0300 > Cc: Eli Zaretskii , me@eshelyaron.com, 71466@debbugs.gnu.org > From: Dmitry Gutov > > On 24/06/2024 09:27, Juri Linkov wrote: > > I still don't understand how duplicating revert-buffer > > > > +(defun xref-revert-buffer () > > + "Refresh the search results in the current buffer." > > + (declare (obsolete revert-buffer "30.1")) > > + (interactive) > > + (let (restore-functions) > > + (when (boundp 'revert-buffer-restore-functions) > > + (run-hook-wrapped 'revert-buffer-restore-functions > > + (lambda (f) (push (funcall f) restore-functions) nil))) > > + (prog1 (xref--revert-buffer) > > + (mapc #'funcall (delq nil restore-functions))))) > > > > can be better than what Eshel proposed with an alias: > > > > + (define-obsolete-function-alias 'xref-revert-buffer #'revert-buffer "30.1") > > That is my opinion as well: better obsolete it this way. Why obsolete it at all? If we use an alias without obsoleting, I think everyone wins. No?