From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: MPS: dangling markers Date: Wed, 03 Jul 2024 22:20:00 +0300 Message-ID: <86tth69tb3.fsf@gnu.org> References: <87v81u85hv.fsf@localhost> <1osQTI7Swoo72EJbCzzi4zqVXuC5hSlYEXwLtnal8_pyYL7oRCNSJg20XgBRjffZ344Wj7lwFDc9JSMsQ-3su6uXQ8hYSfYleRn-4GRrykI=@protonmail.com> <868qyldjqi.fsf@gnu.org> <_nyaStUr9UjwGJZ-bqaGNyxgCMuh-bglMdWw2rpGNja9pdNct6lfF2QXthIQFfjn2-n-T3R4WCuHMLdmIuoRzzAfuHrw0Q1rq3V-5oFLzDE=@protonmail.com> <8634osdohs.fsf@gnu.org> <6r7qNfDbwPzVsGeV6BB2z9gd_MVhUNLrf7m1eBXvyxTr7VDb6VnyD422kOfqblwlnDLSeaIAQExSREX2ZnoQDPsOqFGX1XqdcHXTpIHIhEs=@protonmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39598"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, yantar92@posteo.net, monnier@iro.umontreal.ca, emacs-devel@gnu.org, eller.helmut@gmail.com To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 03 21:21:09 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sP5XR-0009za-G3 for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Jul 2024 21:21:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sP5WZ-0007gi-5Q; Wed, 03 Jul 2024 15:20:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sP5WX-0007fd-3f for emacs-devel@gnu.org; Wed, 03 Jul 2024 15:20:13 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sP5WN-00029G-U8; Wed, 03 Jul 2024 15:20:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Hj7VohYUoKcrx81M2SJm+E984oj1HOg3DtFBzL1FRGw=; b=VLYzOGNC0Rlx gK6lWTMSZErQeiztUbxL9Jq6ir0mBFPzEWSFO10rSYYVudxN1BiDrPzQ1481Sog8demHdyMydhwgZ 3iuF3QgjXxojvdLOwyTkJwvQ/+0uPIO8n9+VvfMb8YRJIGGCVNjEidwKhuXQYiMsEQMOXSaQLD3sr kX2Y2cpG4nuW3sjDLJb5OzsoYo0nBOVnPDnjrBrlMRRyJJDNb/h8iFokTDUTNl+3eCw/69Iyr0K4y FfWYDARS/LTItMiQy3r5PiryzLsFzN+cZVHN4aDn8JjZLruYfpK8C5KTtVhROba97vQrMnZMI0BQ4 j2Cs8/k2BhcSAo/9ANNNPQ==; In-Reply-To: <6r7qNfDbwPzVsGeV6BB2z9gd_MVhUNLrf7m1eBXvyxTr7VDb6VnyD422kOfqblwlnDLSeaIAQExSREX2ZnoQDPsOqFGX1XqdcHXTpIHIhEs=@protonmail.com> (message from Pip Cet on Wed, 03 Jul 2024 18:46:31 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321279 Archived-At: > Date: Wed, 03 Jul 2024 18:46:31 +0000 > From: Pip Cet > Cc: gerd.moellmann@gmail.com, yantar92@posteo.net, monnier@iro.umontreal.ca, emacs-devel@gnu.org, eller.helmut@gmail.com > > On Tuesday, July 2nd, 2024 at 11:25, Eli Zaretskii wrote: > > > Date: Mon, 01 Jul 2024 21:08:07 +0000 > > > > > From: Pip Cet pipcet@protonmail.com > > > Cc: gerd.moellmann@gmail.com, yantar92@posteo.net, monnier@iro.umontreal.ca, emacs-devel@gnu.org, eller.helmut@gmail.com > > > > > > Sorry, it took me a while to reproduce this because the default build worked fine, I had to --enable-checking to get something like your error, though in my case it was clearly the set_weak_hash_hash_value call that was to blame. > > > > > > I incorrectly assumed sxhash, Fsxhash, and the hash value in an equal-based hash table were all the same number; in reality, sxhash is 32 bits on a 32-bit system, 64 bits on a 64-bit system, Fsxhash is 30 bits on a 32-bit system, 62 bits on a 64-bit system, and the hash value is 32 bits on all systems. > > > > > > Long story short, would you be able to try this patch and see whether you get a clean dump? I do here... > > > > > > Yes, this fixes the build, thanks. > > I've pushed a fix. I'm now doing precisely what Fsxhash does rather than simply trimming off bits until we fit into a fixnum. Thanks, the build succeeds now.