From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71958: [PATCH] Improve `tab-line-tabs-fixed-window-buffers` sorting performance Date: Sat, 06 Jul 2024 09:23:36 +0300 Message-ID: <86tth35993.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40778"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71958@debbugs.gnu.org To: Eval Exec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 06 08:24:15 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPyqF-000ANc-3b for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Jul 2024 08:24:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPyq0-0000r4-Mk; Sat, 06 Jul 2024 02:24:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPypz-0000qV-Hy for bug-gnu-emacs@gnu.org; Sat, 06 Jul 2024 02:23:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPypz-0001CV-9R for bug-gnu-emacs@gnu.org; Sat, 06 Jul 2024 02:23:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPyq1-0005qP-P9 for bug-gnu-emacs@gnu.org; Sat, 06 Jul 2024 02:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Jul 2024 06:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71958 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71958-submit@debbugs.gnu.org id=B71958.172024702922443 (code B ref 71958); Sat, 06 Jul 2024 06:24:01 +0000 Original-Received: (at 71958) by debbugs.gnu.org; 6 Jul 2024 06:23:49 +0000 Original-Received: from localhost ([127.0.0.1]:45410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPypo-0005pv-Uh for submit@debbugs.gnu.org; Sat, 06 Jul 2024 02:23:49 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPypm-0005pi-T0 for 71958@debbugs.gnu.org; Sat, 06 Jul 2024 02:23:47 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPypd-0000em-QO; Sat, 06 Jul 2024 02:23:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZAE8GMn0TgRCqDxY7hULz5H3pj08slnDJgLV6ZtCufI=; b=Z5m0MODPyUgq x46j0AUa5GoHBZnV5OtGPT6U6kVxzh0ZYBRjTZ7lIaTnebLM+HMG9Ae9KrUA1C6sNKEaZuVzXPkiB Hv87yg8ZAJbt00rvc0kFDRzTUAJ392fEpt4ru/KSphVAwQjxWZUvqPozZ9+I4KmQevR8ikgE/kJKi XLq2N28Xwuf6E6vF/iMW2OsAGyw6jOtow6oAo/a+mwosMy/wfovGebYfg/K8OqvLtFWRk/CaKGjGk aynvRmcHIRr/rrH62xEGjzNmi8Vf8Op4GAi1UCqvurlWfgQU9aF7CAVTwx7sKxn0bQLDUsGqgqpd2 Og4JVKFwfUaax1WfRB6FCw==; In-Reply-To: (message from Eval Exec on Fri, 5 Jul 2024 19:11:54 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288456 Archived-At: > From: Eval Exec > Date: Fri, 5 Jul 2024 19:11:54 +0800 Thanks. I'll leave it to Juri to review the code and comment, but just minor nits on your commit log message: > * lsp/tab-line.el (tab-line-tabs-fixed-window-buffers): Enhanced > `tab-line-tabs-fixed-window-buffers` performance by optimizing buffer > sorting mechanism. Replaced inefficient `seq-position` calls with a hash > table to cache buffer positions, significantly improving speed when > handling large buffer lists. Our style is to say "Enhance" and "Replace", not "Enhanced" and "Replaced". Also, we use the US English convention of leaving two spaces between sentences. Finally, please quote symbols 'like this', not `like this`. In addition, I'd encourage you to start your legal paperwork of assigning the copyright to the FSF at this time, so we could accept your contributions without any restrictions. If you are willing to start the paperwork now, I will send you the form to fill and the instructions to go with it.