all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Eval Exec <execvy@gmail.com>
Cc: 71958@debbugs.gnu.org
Subject: bug#71958: [PATCH] Improve `tab-line-tabs-fixed-window-buffers` sorting performance
Date: Sat, 06 Jul 2024 09:23:36 +0300	[thread overview]
Message-ID: <86tth35993.fsf@gnu.org> (raw)
In-Reply-To: <CAKfPJDqEVRKyKFC6w0vayTZF+dG4m28nGwbX74bis41w8hCvaA@mail.gmail.com> (message from Eval Exec on Fri, 5 Jul 2024 19:11:54 +0800)

> From: Eval Exec <execvy@gmail.com>
> Date: Fri, 5 Jul 2024 19:11:54 +0800

Thanks.  I'll leave it to Juri to review the code and comment, but
just minor nits on your commit log message:

> * lsp/tab-line.el (tab-line-tabs-fixed-window-buffers): Enhanced
> `tab-line-tabs-fixed-window-buffers` performance by optimizing buffer
> sorting mechanism. Replaced inefficient `seq-position` calls with a hash
> table to cache buffer positions, significantly improving speed when
> handling large buffer lists.

Our style is to say "Enhance" and "Replace", not "Enhanced" and
"Replaced".  Also, we use the US English convention of leaving two
spaces between sentences.  Finally, please quote symbols 'like this',
not `like this`.

In addition, I'd encourage you to start your legal paperwork of
assigning the copyright to the FSF at this time, so we could accept
your contributions without any restrictions.  If you are willing to
start the paperwork now, I will send you the form to fill and the
instructions to go with it.





  reply	other threads:[~2024-07-06  6:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-05 11:11 bug#71958: [PATCH] Improve `tab-line-tabs-fixed-window-buffers` sorting performance Eval Exec
2024-07-06  6:23 ` Eli Zaretskii [this message]
2024-07-07 16:51   ` Juri Linkov
2024-07-07 17:33     ` Eli Zaretskii
2024-07-07 18:24       ` Juri Linkov
2024-07-09  2:46       ` Richard Stallman
2024-07-13  2:21       ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86tth35993.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=71958@debbugs.gnu.org \
    --cc=execvy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.