From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71504: 30.0.50; FR: Fix suggestions ("quick fix") for Flymake diagnostics Date: Fri, 12 Jul 2024 09:35:13 +0300 Message-ID: <86ttgvkti6.fsf@gnu.org> References: <865xtu7seh.fsf@gnu.org> <868qyf5587.fsf@gnu.org> <868qyd32ih.fsf@gnu.org> <861q452s5f.fsf@gnu.org> <86frsgmpe1.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28130"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sbaugh@janestreet.com, 71504@debbugs.gnu.org To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 12 08:36:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sS9tE-000792-40 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Jul 2024 08:36:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sS9sz-00060j-Mh; Fri, 12 Jul 2024 02:36:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sS9sx-0005zq-Ls for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2024 02:36:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sS9sx-0002gO-BM for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2024 02:36:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sS9sw-0001XY-Dv for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2024 02:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Jul 2024 06:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71504 X-GNU-PR-Package: emacs Original-Received: via spool by 71504-submit@debbugs.gnu.org id=B71504.17207661445893 (code B ref 71504); Fri, 12 Jul 2024 06:36:02 +0000 Original-Received: (at 71504) by debbugs.gnu.org; 12 Jul 2024 06:35:44 +0000 Original-Received: from localhost ([127.0.0.1]:53040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sS9se-0001Wz-3R for submit@debbugs.gnu.org; Fri, 12 Jul 2024 02:35:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sS9sc-0001Wn-Ub for 71504@debbugs.gnu.org; Fri, 12 Jul 2024 02:35:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sS9sX-0001pO-4r; Fri, 12 Jul 2024 02:35:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=U3yP9QPXj30T7R3XgP4aAITPsf7RegkDJa+uPZ5YEYI=; b=Eu4n5IalyAeC XdUe29D5o/UCBWuh5jmhB4eKCAVU5v726Y340lxDtyf1L9XefFlpoVH8vFFupYyS9Q/ZDwzITvSH3 3BWgyc1ja6w1XfDLdkp9sL6V1Tnuyz5AU6SFPdtLbkmlKkKmVRhE0lKesbR87YEL8w0FHWGXI4OAq YGtwByffV/yS0TGI51ENjgwAysw7qODZA4gNDkwzoT7D+2LC2aSUtcE9E9aMGZQhhFiDiFIAdi63i a8enVXx+QXsCZSxjMfbJkIv8X4oqIdNIe9v+RAhyTIrkN/J+pLJjvk83zWIxSVG30FFCb7NU1/WEV 4STZZUz7OopYr8wRfc5ZQQ==; In-Reply-To: (message from Eshel Yaron on Thu, 11 Jul 2024 09:28:35 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288759 Archived-At: > From: Eshel Yaron > Cc: sbaugh@janestreet.com, 71504@debbugs.gnu.org > Date: Thu, 11 Jul 2024 09:28:35 +0200 > > Eli Zaretskii writes: > > > I'm asking what is the overall idea of the proposed implementation. I > > think it's worthwhile to present it, so we could see if we all agree > > with that idea and the details of the proposed implementation. > > Thanks. To clarify, ideally Spencer will implement this feature request > however he sees fit. I'm offering my implementation as a reference, but > I'm not advocating for it over other alternatives that may come up. > > The idea of my implementation is to allow Flymake backends to associate > fixes with some of the diagnostics they create, and to add a command > that tries to apply a fix for the diagnostic at point. For the details, > see below the same patch I attached to this message: > https://lists.gnu.org/archive/html/emacs-devel/2024-05/msg01318.html Thanks. If this is okay with Spencer, I think this should go to the master branch, with the following two nits fixed: . the doc string of flymake-make-diagnostic should explicitly tell that :fix-function is for backends to be set to the appropriate fixup function . this is documented in flymake.texi