From: Eli Zaretskii <eliz@gnu.org>
To: Eshel Yaron <me@eshelyaron.com>
Cc: sbaugh@janestreet.com, 71504@debbugs.gnu.org
Subject: bug#71504: 30.0.50; FR: Fix suggestions ("quick fix") for Flymake diagnostics
Date: Fri, 12 Jul 2024 09:35:13 +0300 [thread overview]
Message-ID: <86ttgvkti6.fsf@gnu.org> (raw)
In-Reply-To: <m1cynks7z0.fsf@dazzs-mbp.home> (message from Eshel Yaron on Thu, 11 Jul 2024 09:28:35 +0200)
> From: Eshel Yaron <me@eshelyaron.com>
> Cc: sbaugh@janestreet.com, 71504@debbugs.gnu.org
> Date: Thu, 11 Jul 2024 09:28:35 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > I'm asking what is the overall idea of the proposed implementation. I
> > think it's worthwhile to present it, so we could see if we all agree
> > with that idea and the details of the proposed implementation.
>
> Thanks. To clarify, ideally Spencer will implement this feature request
> however he sees fit. I'm offering my implementation as a reference, but
> I'm not advocating for it over other alternatives that may come up.
>
> The idea of my implementation is to allow Flymake backends to associate
> fixes with some of the diagnostics they create, and to add a command
> that tries to apply a fix for the diagnostic at point. For the details,
> see below the same patch I attached to this message:
> https://lists.gnu.org/archive/html/emacs-devel/2024-05/msg01318.html
Thanks.
If this is okay with Spencer, I think this should go to the master
branch, with the following two nits fixed:
. the doc string of flymake-make-diagnostic should explicitly tell
that :fix-function is for backends to be set to the appropriate
fixup function
. this is documented in flymake.texi
next prev parent reply other threads:[~2024-07-12 6:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 8:43 bug#71504: 30.0.50; FR: Fix suggestions ("quick fix") for Flymake diagnostics Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-27 7:32 ` Eli Zaretskii
2024-06-27 13:35 ` Spencer Baugh
2024-06-27 18:15 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-06 7:50 ` Eli Zaretskii
2024-07-07 8:53 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-07 10:44 ` Eli Zaretskii
2024-07-07 11:50 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-07 14:28 ` Eli Zaretskii
2024-07-11 5:43 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-11 6:08 ` Eli Zaretskii
2024-07-11 7:28 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-12 6:35 ` Eli Zaretskii [this message]
2024-07-16 9:49 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-16 10:28 ` Eli Zaretskii
2024-07-16 15:19 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-16 15:33 ` Eli Zaretskii
2024-07-16 21:27 ` Spencer Baugh
2024-07-17 11:51 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-24 16:40 ` Spencer Baugh
2024-07-24 17:44 ` João Távora
2024-07-25 9:04 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ttgvkti6.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=71504@debbugs.gnu.org \
--cc=me@eshelyaron.com \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.