From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [MPS-test] scratch/igc branch (commit: 42731228d24) crashed Date: Mon, 05 Aug 2024 20:45:02 +0300 Message-ID: <86ttfyq2xt.fsf@gnu.org> References: <87plqnuekc.fsf@protonmail.com> <9d5pSofW1FhcAKO7fyf_c8hAwDE8aiuiDGWFglQZI-1FwaDY3KBS5zPkKt0nKUkzs0McRm9kHq47qZjzTz0rgfde5QfLH0v0KdgUxVXI6GA=@protonmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17250"; mail-complaints-to="usenet@ciao.gmane.io" Cc: execvy@gmail.com, emacs-devel@gnu.org To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 05 19:45:48 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sb1mG-0004JJ-B6 for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Aug 2024 19:45:48 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sb1lo-0004Dp-9Q; Mon, 05 Aug 2024 13:45:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sb1ll-0004DZ-W6 for emacs-devel@gnu.org; Mon, 05 Aug 2024 13:45:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sb1ll-0003tm-Fe; Mon, 05 Aug 2024 13:45:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/euyTCRR3rAF8chhwAYUxVTTwsk8Cdun3EFeV/QjQRo=; b=c9G4QbeWlCjb AR6seHFImRAubQvY0JQUIKOPxV2WoZHOb08b4pvajAaEbm6W/62BkC7mOL/AIZAM1jxxVby95KlKu OXWdftlRlfQz78othloKYwcsEZiABijuTlGp7X1EOqIfGgt4GOsr2wrtTIHpaIf+P/cTSfgsZfvfw YcNT0pQWlxkCNMQ12D+pIDEYR3EzHEDdfSOHonOYUl+x2mOL2Mo4QI7NEmDO6qehedX3XTkLUnpYG Z63xLyPvALcU88jFTyNhQqq3kemx4tqi7zprJul4f07oQMXE5Qku3Uh7zLuaYuEIlpSImHCBMmAyc fts/OIyQov/37G11M25yGw==; In-Reply-To: <9d5pSofW1FhcAKO7fyf_c8hAwDE8aiuiDGWFglQZI-1FwaDY3KBS5zPkKt0nKUkzs0McRm9kHq47qZjzTz0rgfde5QfLH0v0KdgUxVXI6GA=@protonmail.com> (message from Pip Cet on Mon, 05 Aug 2024 16:40:50 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322402 Archived-At: > Date: Mon, 05 Aug 2024 16:40:50 +0000 > From: Pip Cet > Cc: Eval Exec , emacs-devel@gnu.org > > So I've done that, can you try the attached patch? This is a first stab (thus the ambiguous alloc), but it should prevent the crash we've seen. > > TODO list for this: > - use precise alloc > - check framep, not *framep, in EmacsFrameInitialize The inclusion of igc.h should be conditioned by HAVE_MPS.