From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72809: ms-windows: Copyright embedded into executable is outdated Date: Sat, 14 Sep 2024 17:02:47 +0300 Message-ID: <86tteifi48.fsf@gnu.org> References: <726bb0bf-18d6-4963-8dbe-5151c6da4926@imayhem.com> <86frqnfsd6.fsf@gnu.org> <86mskaitfa.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23540"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72809@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 14 16:04:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1spTNk-00060K-3O for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Sep 2024 16:04:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1spTNR-0004mH-L7; Sat, 14 Sep 2024 10:03:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spTNP-0004lu-F4 for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2024 10:03:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1spTNP-0000Dh-63 for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2024 10:03:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=90Pe9XRzxxxdD7YoxgzhmeCzvl9nRHRgMTjtAZZH71g=; b=uwpD6I7rt6C+CkXvq88eiCMzt442G/5oAUxzPrs2CP1sbWcZc4wkNExwaxzNLefGuMAzqG/djdFZ3JMbLY//u0I9P466AfJ2/+cYvVKCaJdKw3pYkJq7c0a+HXdttx2kkwfRwNRA8zYJ+ciDNDnBNgfnjGTPKmJrUnKiwKgDPKu85R4EFrf+fYjpc5CXjw6Hli6DfhFNwYeFr60DlEfbgFet0ghvzVMSR6KD547AUUJTgPiPZz60cRFy9P86oXGzO+hpR01BA8vw10gXd5q1xT3lLRwmfpgDKu/Fx27SustAdRv6CrwXEOpiYfZzp36tlCbG1e1BG0VDEQcEDvxrIQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1spTNZ-0000H7-MU for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2024 10:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Sep 2024 14:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72809 X-GNU-PR-Package: emacs Original-Received: via spool by 72809-submit@debbugs.gnu.org id=B72809.1726322588960 (code B ref 72809); Sat, 14 Sep 2024 14:04:01 +0000 Original-Received: (at 72809) by debbugs.gnu.org; 14 Sep 2024 14:03:08 +0000 Original-Received: from localhost ([127.0.0.1]:47417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spTMi-0000FP-CA for submit@debbugs.gnu.org; Sat, 14 Sep 2024 10:03:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spTMg-0000Ee-7P for 72809@debbugs.gnu.org; Sat, 14 Sep 2024 10:03:07 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spTMP-00009M-Kx; Sat, 14 Sep 2024 10:02:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=90Pe9XRzxxxdD7YoxgzhmeCzvl9nRHRgMTjtAZZH71g=; b=Ggg/yTGnQ6WI AWfj+OQRNygJXkshDgkyQsig+fJT7JfIPcwriwKQ6TgrvUtrNRT6Tsvs8jgukjZW6DZqoY7mlk/kA m6Ol8iWg2XM5V/ABjM0B5m28MDjXBGof5Jgn/0huKrFuA64A0Mi0B0KCarXwHqCvtIrM9SIPTtGyp /fAi9SdYeV5+k+unLIuMO+zL/2jPswIc1dAqXOa6j0O9SjExK4gzQQj5GmMO+xVaBRiAYxXdR333d xt3PhGSjm36fmuxO72niub6dCH18BY7IelC6uNv98kYFwzbJDA6IilKRvjgkNY1uNWg/mbcjUDYmm AuPNHhPOp95rIStAZTn28A==; In-Reply-To: (message from Stefan Kangas on Sat, 14 Sep 2024 06:28:15 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291752 Archived-At: > From: Stefan Kangas > Date: Sat, 14 Sep 2024 06:28:15 -0700 > Cc: 72809@debbugs.gnu.org > > Eli Zaretskii writes: > > > Stefan, what are your thoughts about improving the script? Do you > > understand why these files were missed? > > The simple reason is that the Gnulib `build-aux/update-copyright` script > don't support them, so we need to remember to update them manually. > > As for why this is, the cases are different. > > 1. There's more than one copyright year in these files: > > configure.ac > doc/lispref/tips.texi > etc/images/gud/README > > However, the Gnulib script only updates the first copyright year. > > 2. For these files: > > nt/emacs.rc.in > nt/emacsclient.rc.in > > the Gnulib script does not support making this update: > > - VALUE "LegalCopyright", "Copyright (C) 2001-2021\0" > + VALUE "LegalCopyright", "Copyright (C) 2001-2024\0" > > 3. This file: > > test/lisp/which-key-tests.el > > was added with the wrong copyright in 2024. > > There are even more edge cases, see for example commit 33d159c36f42. > > I'm not sure if it's worth updating our script to support all this. > It's not too hard to remember to grep for "202[0-9]" and updating them > manually. Writing code to do this has a maintenance cost too, and also > runs a risk of missing some years. Files change, new files are added, > etc. So there's no way around grepping to make sure, I think. > > Thus, perhaps we should just do this: > > diff --git a/admin/update-copyright b/admin/update-copyright > index b9007100b35..23b78443ca4 100755 > --- a/admin/update-copyright > +++ b/admin/update-copyright > @@ -77,3 +77,6 @@ updatable_files= > -print) && > > build-aux/update-copyright $updatable_files > + > +printf "!! Please remember to grep for and manually update any" > +printf "!! copyright years that were not updated by this script." That's okay, but could you also update admin/notes/years? That file seems to be severely outdated (e.g., it mentions files we no longer have), and I think it would be good to add what you say here to the text, including the list of files that need manual updates. Thanks.