From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Accidental change of behaviour for electric-layout-mode? Date: Wed, 25 Sep 2024 18:57:46 +0300 Message-ID: <86tte3bu9x.fsf@gnu.org> References: <87wmj2dr4q.fsf@ice9.digital> <86v7yle1ma.fsf@gnu.org> <86cyktdx68.fsf@gnu.org> <871q18op24.fsf@ice9.digital> <86msjwdgcq.fsf@gnu.org> <87r098n8n5.fsf@ice9.digital> <86jzf0c6rw.fsf@gnu.org> <87h6a37sh0.fsf@ice9.digital> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15089"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Morgan Willcock Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 25 17:58:26 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1stUPJ-0003h0-Lk for ged-emacs-devel@m.gmane-mx.org; Wed, 25 Sep 2024 17:58:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stUOn-0000RX-Fs; Wed, 25 Sep 2024 11:57:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stUOk-0000RF-FW for emacs-devel@gnu.org; Wed, 25 Sep 2024 11:57:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stUOj-00070n-2u; Wed, 25 Sep 2024 11:57:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rDammagmRW//rj4uwcxZPjBq96SSMm25B7O+LkPZ+ck=; b=Rrq1L8IT6k0B QeVdUcQblne95VTOMN6dkcpln16bDEj3o5PEwZdeYG1YZSTsk350TaH3XHxG+CtBf6UIWv3JjAZQ7 hvncSnBJtT6y77ecOXYAEt1lMCooIwwn9tApjr83/aEY7Neyltq4+Ulfet9nsjE7xYG5yZ24JCAgY pmDpVPejZwWOYKVKSN718KjltvDZf67vaO/qVrbzoonUbobBjdszDme2gQrzxjoG/xVC9BsZx4hvw CuBpAwCPXtzh8QkW98pfjw+XSRaGBWgbKJXskLK5QgRgL/X8dLSY11EWPPe+XzbX+MVmCMX280Gr8 PpmTgeIp81UyEjbQzeLQcw==; In-Reply-To: <87h6a37sh0.fsf@ice9.digital> (message from Morgan Willcock on Wed, 25 Sep 2024 14:50:19 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324076 Archived-At: > From: Morgan Willcock > Cc: emacs-devel@gnu.org > Date: Wed, 25 Sep 2024 14:50:19 +0100 > > Just to make sure everything works in Emacs 30, I'd rather just revert > the accidental change than get further involved in the development of > this feature (at least in the short term). > > I've attached a patch which just reverts the change that was > accidentally applied. This should be all that is needed unless you > specifically want to accommodate features which accidentally worked in > an unreleased version of Emacs. Actually, having the variable is better, because we have run with this code for quite some time, and someone might rely on the unintended feature. So I think your original patch is better.