Re: master 29bf0a8b31b 1/2: ; * etc/NEWS: Fix typos.

Re: master 29bf0a8b31b 1/2: ; * etc/NEWS: Fix typos.

[Sean Whitton]

Hello Michael,

On Sun 13 Oct 2024 at 09:41am -04, Michael Albinus via Mailing list for Emacs changes wrote:

> @@ -61,7 +62,8 @@ The 'find-function', 'find-library', 'find-face-definition', and
>  usual minibuffer history commands.  Each command has a separate history.
>
>  ---
> -** New minor mode find-function-mode replaces the old find-function-setup-keys.
> +** New minor mode 'find-function-mode'.
> +It replaces the old 'find-function-setup-keys'.
>
>  ** Minibuffer and Completions

This was not a typo.  It was deliberately written as a single line.
I'd like to revert this hunk, if you don't mind.

-- 
Sean Whitton

Re: master 29bf0a8b31b 1/2: ; * etc/NEWS: Fix typos.

[Michael Albinus]

Sean Whitton <spwhitton@spwhitton.name> writes:

> Hello Michael,

Hi Sean,

> On Sun 13 Oct 2024 at 09:41am -04, Michael Albinus via Mailing list for Emacs changes wrote:
>
>> @@ -61,7 +62,8 @@ The 'find-function', 'find-library', 'find-face-definition', and
>>  usual minibuffer history commands.  Each command has a separate history.
>>
>>  ---
>> -** New minor mode find-function-mode replaces the old find-function-setup-keys.
>> +** New minor mode 'find-function-mode'.
>> +It replaces the old 'find-function-setup-keys'.
>>
>>  ** Minibuffer and Completions
>
> This was not a typo.  It was deliberately written as a single line.
> I'd like to revert this hunk, if you don't mind.

Your version misses the quotation 'like-this' for Lisp symbols. And
after adding it, the line was too long, more than 80 characters.

If you find another wording, which solves these deficiencies, I don't
mind any change.

Best regards, Michael.

Re: master 29bf0a8b31b 1/2: ; * etc/NEWS: Fix typos.

[Robert Pluim]

>>>>> On Thu, 17 Oct 2024 16:52:10 +0200, Michael Albinus <michael.albinus@gmx.de> said:

    Michael> Sean Whitton <spwhitton@spwhitton.name> writes:
    >> Hello Michael,

    Michael> Hi Sean,

    >> On Sun 13 Oct 2024 at 09:41am -04, Michael Albinus via Mailing list for Emacs changes wrote:
    >> 
    >>> @@ -61,7 +62,8 @@ The 'find-function', 'find-library', 'find-face-definition', and
    >>> usual minibuffer history commands.  Each command has a separate history.
    >>> 
    >>> ---
    >>> -** New minor mode find-function-mode replaces the old find-function-setup-keys.
    >>> +** New minor mode 'find-function-mode'.
    >>> +It replaces the old 'find-function-setup-keys'.
    >>> 
    >>> ** Minibuffer and Completions
    >> 
    >> This was not a typo.  It was deliberately written as a single line.
    >> I'd like to revert this hunk, if you don't mind.

    Michael> Your version misses the quotation 'like-this' for Lisp symbols. And
    Michael> after adding it, the line was too long, more than 80 characters.

    Michael> If you find another wording, which solves these deficiencies, I don't
    Michael> mind any change.

    Michael> Best regards, Michael.

** New minor mode 'find-function-modeʼ, replaces 'find-function-setup-keysʼ.

76 characters :-)

Robert
-- 

Re: master 29bf0a8b31b 1/2: ; * etc/NEWS: Fix typos.

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: Sean Whitton <spwhitton@spwhitton.name>,  emacs-devel@gnu.org
> Date: Thu, 17 Oct 2024 17:03:48 +0200
> 
> >>>>> On Thu, 17 Oct 2024 16:52:10 +0200, Michael Albinus <michael.albinus@gmx.de> said:
> 
>     Michael> Sean Whitton <spwhitton@spwhitton.name> writes:
>     >> Hello Michael,
> 
>     Michael> Hi Sean,
> 
>     >> On Sun 13 Oct 2024 at 09:41am -04, Michael Albinus via Mailing list for Emacs changes wrote:
>     >> 
>     >>> @@ -61,7 +62,8 @@ The 'find-function', 'find-library', 'find-face-definition', and
>     >>> usual minibuffer history commands.  Each command has a separate history.
>     >>> 
>     >>> ---
>     >>> -** New minor mode find-function-mode replaces the old find-function-setup-keys.
>     >>> +** New minor mode 'find-function-mode'.
>     >>> +It replaces the old 'find-function-setup-keys'.
>     >>> 
>     >>> ** Minibuffer and Completions
>     >> 
>     >> This was not a typo.  It was deliberately written as a single line.
>     >> I'd like to revert this hunk, if you don't mind.
> 
>     Michael> Your version misses the quotation 'like-this' for Lisp symbols. And
>     Michael> after adding it, the line was too long, more than 80 characters.
> 
>     Michael> If you find another wording, which solves these deficiencies, I don't
>     Michael> mind any change.
> 
>     Michael> Best regards, Michael.
> 
> ** New minor mode 'find-function-modeʼ, replaces 'find-function-setup-keysʼ.
> 
> 76 characters :-)

You can drop the comma, and then its 75.

Re: master 29bf0a8b31b 1/2: ; * etc/NEWS: Fix typos.

[Sean Whitton]

Hello,

On Thu 17 Oct 2024 at 04:52pm +02, Michael Albinus wrote:

> Your version misses the quotation 'like-this' for Lisp symbols. And
> after adding it, the line was too long, more than 80 characters.
>
> If you find another wording, which solves these deficiencies, I don't
> mind any change.

Oh, thank you, and thank you for going through all of NEWS like you have.

On Thu 17 Oct 2024 at 06:21pm +03, Eli Zaretskii wrote:

> Btw, why is it so important to have this in a single line?

It's not that important.  I think in this case it is nice how it
deemphasises a less important change as compared with all the new
features.

-- 
Sean Whitton

Re: master 29bf0a8b31b 1/2: ; * etc/NEWS: Fix typos.

[Eli Zaretskii]

> From: Sean Whitton <spwhitton@spwhitton.name>
> Cc: emacs-devel@gnu.org
> Date: Fri, 18 Oct 2024 12:32:11 +0800
> 
> On Thu 17 Oct 2024 at 06:21pm +03, Eli Zaretskii wrote:
> 
> > Btw, why is it so important to have this in a single line?
> 
> It's not that important.  I think in this case it is nice how it
> deemphasises a less important change as compared with all the new
> features.

I asked the question because IME shorter sentences tend to make it
easier to understand complicated issues.  So if you can break a long
sentence into several shorter ones, it is generally advisable to do
that.

There's also a special consideration for NEWS: if the user reads NEWS
in folded mode, a shorter heading will allow easier skipping over
stuff that is not interesting for the user.

Re: master 29bf0a8b31b 1/2: ; * etc/NEWS: Fix typos.

[Eli Zaretskii]

> From: Sean Whitton <spwhitton@spwhitton.name>
> Cc: Michael Albinus <michael.albinus@gmx.de>
> Date: Thu, 17 Oct 2024 22:40:26 +0800
> 
> > -** New minor mode find-function-mode replaces the old find-function-setup-keys.
> > +** New minor mode 'find-function-mode'.
> > +It replaces the old 'find-function-setup-keys'.
> >
> >  ** Minibuffer and Completions
> 
> This was not a typo.  It was deliberately written as a single line.

Btw, why is it so important to have this in a single line?

Re: master 29bf0a8b31b 1/2: ; * etc/NEWS: Fix typos.

[Christopher Howard]

> Does this happen when you byte-compile the bookmark+ files? Or only
> when you use the .el files?

I believe I am just using the .el files, and not byte-compiling, at least not on purpose.

I'm not very knowledgeable at this point on what triggers byte-compiling, and how things are cached. So, conceivably I might be using byte-compiled code unintentionally. I was originally running bookmark+ from guix repository and then uninstalled that. And then I cloned it from the git mirror and loaded that, using load-path and require. Then finally I downloaded all the files from emacswiki into a directory and was using loadpath and require to load that.

There does not appear to be any settings in my init.el file pertaining to byte compiling or native compiling, so presumably I am using whatever the default settings are for Emacs 30.0.91.

-- 
Christopher Howard