From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: master 4a49c50a4c3 1/2: VC Git: Use vc-deduce-fileset to
 determine what to stash
Date: Tue, 29 Oct 2024 15:12:32 +0200
Message-ID: <86ttcv59z3.fsf@gnu.org>
References: <865xpb6qx0.fsf@gnu.org> <87o733dr7t.fsf@melete.silentflame.com>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="34874"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Sean Whitton <spwhitton@spwhitton.name>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 29 14:13:28 2024
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1t5m2K-0008si-AU
	for ged-emacs-devel@m.gmane-mx.org; Tue, 29 Oct 2024 14:13:28 +0100
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces@gnu.org>)
	id 1t5m1U-00071k-8u; Tue, 29 Oct 2024 09:12:36 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1t5m1S-00071Y-Sn
 for emacs-devel@gnu.org; Tue, 29 Oct 2024 09:12:34 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1t5m1S-0006Aj-EQ; Tue, 29 Oct 2024 09:12:34 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=Gp6vwBrnMGZQi8IVT1DekbpG724q89f5gU3qOxXFCLE=; b=ZJOIOuM3ofi1
 /0oJhN7ObJN4CdIBSstdrCGl+8PdVeGIwUesNwfAi+TQzWUk8GlLrqD18mVLq2S6m5SYsl1GfphoE
 eczcGXMmoTp2fXISjn0416XA1G2RBDTPNyeyuOVmGG3iNctfvT7snYhTumNq54cdjnQiTk+Qa0zyj
 Lv4ocup6o6pvwWNqhTf/qUwT/OjA5UBP1M18T3JoenwpbjhnSE4NLRn/CVRdZdXFSDsYxn/7qk/J/
 m+tBiGzSzvl2i9crS4FF32INgR0VM5ijjVfg7BefsYHiutzrj0hITe4eWhIB7V7O2L06NdNsFS2p6
 P8WAuQeZkEnyggRdFEhWlA==;
In-Reply-To: <87o733dr7t.fsf@melete.silentflame.com> (message from Sean
 Whitton on Tue, 29 Oct 2024 20:32:54 +0800)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.devel:324910
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/324910>

> From: Sean Whitton <spwhitton@spwhitton.name>
> Cc: emacs-devel@gnu.org
> Date: Tue, 29 Oct 2024 20:32:54 +0800
> 
> >>     * lisp/vc/vc-git.el (vc-git--deduce-files-for-stash): New function.
> >>     (vc-git-stash, vc-git-stash-snapshot): Use it to determine what
> >>     to stash.  Update and expand docstrings.
> >>     (vc-git-stash-snapshot): No longer unconditionally snapshot all
> >>     uncommitted changes across the whole working tree.
> >
> > This apparently leads to:
> >
> >     ELC      vc/vc-git.elc
> >
> >   In end of data:
> >   vc/vc-git.el:2188:12: Warning: the function `vc-deduce-fileset' might not be defined at runtime.
> 
> Apologies, fixed.

Thanks.