From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: New "make benchmark" target Date: Tue, 31 Dec 2024 14:53:29 +0200 Message-ID: <86ttakm2t2.fsf@gnu.org> References: <87h679kftn.fsf@protonmail.com> <87frm51jkr.fsf@protonmail.com> <861pxpp88q.fsf@gnu.org> <87frm5z06l.fsf@protonmail.com> <86msgdnqmv.fsf@gnu.org> <87wmfhxjce.fsf@protonmail.com> <86jzbhnmzg.fsf@gnu.org> <87o70txew4.fsf@protonmail.com> <86frm5nii8.fsf@gnu.org> <87jzbgpkon.fsf@protonmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11181"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acorallo@gnu.org, stefankangas@gmail.com, mattiase@acm.org, eggert@cs.ucla.edu, emacs-devel@gnu.org To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 31 13:54:58 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tSbly-0002jx-6M for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Dec 2024 13:54:58 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tSblM-0006iY-G4; Tue, 31 Dec 2024 07:54:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSblK-0006iO-5H for emacs-devel@gnu.org; Tue, 31 Dec 2024 07:54:18 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSblI-0003Qb-7p; Tue, 31 Dec 2024 07:54:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=n/lNFrlYV2YKSxUMr7o1KsOwTMetGAsifrWauoubY2Y=; b=V3xFbQUV2857 EVjhlvgWVihXHpUVfJqY6MmXE3n4jy8y9TsXXL5pxMes0wmhVIvlTQczvr0oSfa84HrQH3BbXqJw1 6N5IEWVhN4rGwcmXKZOGME7/pYvUXpvh1pe62SLCjJvwy0avw5zQPCgNBROtmrtunCH0qU2utKNpS MbskVbON1beUWs53NXd8dPEIoSF81YzPI81cmT82Xw7rWE9don8nWQQxRJgekfeyE1PQCTwgLyENG UcIl+yLHRaLbxRhz2HSn4CwBLkN2UalovTf23LNMKz6P1Nb2tc91fFXudgeb6qWuAuEWfzVD9UdU5 212xZWWvtBh0ZNigN0mI+g==; In-Reply-To: <87jzbgpkon.fsf@protonmail.com> (message from Pip Cet on Tue, 31 Dec 2024 04:00:05 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327497 Archived-At: > Date: Tue, 31 Dec 2024 04:00:05 +0000 > From: Pip Cet > Cc: acorallo@gnu.org, stefankangas@gmail.com, mattiase@acm.org, eggert@cs.ucla.edu, emacs-devel@gnu.org > > "Eli Zaretskii" writes: > > >> Date: Mon, 30 Dec 2024 17:25:44 +0000 > >> From: Pip Cet > >> Cc: acorallo@gnu.org, stefankangas@gmail.com, mattiase@acm.org, eggert@cs.ucla.edu, emacs-devel@gnu.org > >> > >> "Eli Zaretskii" writes: > >> > >> Top-posted TL;DR: let's call Andrea's code "make elisp-benchmarks" and > >> include it now? That would preserve the Git history and importantly (to > >> me) reserve the name for now. > > > > Fine by me. > > Pushed to scratch/elisp-benchmarks. Thanks. > Sorry for all the noise; we should really find a way to reduce > emacs-diffs notifications when many commits are made at once. I see no reason: people who subscribe to that list should be prepared for floods from time to time. > This branch: > > 1. contains whitespace errors, because it contains the files precisely > as they are in the elisp-benchmarks repo We should probably clean that up, unless Andrea says that those whitespace are somehow needed. > >> And I don't usually run ERT tests individually, while I'm trying to get > >> in the habit of running the (non-expensive) test suite before I push. > > > > I do it all the time, when I install some change and want to make sure > > the related tests still pass. > > Interesting: I find it very hard to localize my changes to specific > tests, usually. It is not a 100% reliable technique, but in 99% of the cases, running the tests corresponding to the Lisp file(s) modified by a changeset, followed by additional tests where Grep finds the functions in which the changes were made, provide good coverage (if we have tests for those features at all).