From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#75192: [PATCH] Update fontification for attribute values in heex-ts-mode Date: Thu, 02 Jan 2025 11:06:57 +0200 Message-ID: <86ttahk2j2.fsf@gnu.org> References: <86zfk9k3xr.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9966"; mail-complaints-to="usenet@ciao.gmane.io" Cc: wkirschbaum@gmail.com, casouri@gmail.com, 75192@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 02 10:08:08 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTHBY-0002RH-Hf for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Jan 2025 10:08:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTHBU-0003gW-3T; Thu, 02 Jan 2025 04:08:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTHBS-0003gB-Ca for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 04:08:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tTHBS-0004Ke-3Y for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 04:08:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=4kmcE21YbeG4E0u+VXOtoVgLdn4yIBxeQfPRjTxWmQo=; b=Op7GDuMc9KfgBT/CU5R9HMxBmK7uosCPykP17HYGOTtRjEAQN5G2wNv7pMw4p0Q6TT7N6pWSWxAeO02jkhl6nPzlBOpYGWjuHRNDOt7vEJXLpseyfhJcA9ZoIdYtlSk1xbe8JXbhmlKNST0Oo1+ZGnyCEaD3LBEuSeUZa+4Q9f3gW1wYQmIVsTNrzH3MDEBs1VYln3Nz1QcptqQzslb7H3Lr+bwB7R/qVVxO7zIWu0A9hD9vrnwupFZPAhOxiy7TkUMGhlJceopc5iZB95tOw0QpFKM7q5RQejGlpkm3vxYXvwXn1ZAXdS1VNVuaUkrV9NALsz57jjJaOQ9DivDtEA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tTHBR-0005hE-NS for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 04:08:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Jan 2025 09:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75192 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 75192-submit@debbugs.gnu.org id=B75192.173580883121840 (code B ref 75192); Thu, 02 Jan 2025 09:08:01 +0000 Original-Received: (at 75192) by debbugs.gnu.org; 2 Jan 2025 09:07:11 +0000 Original-Received: from localhost ([127.0.0.1]:42747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTHAc-0005gC-MP for submit@debbugs.gnu.org; Thu, 02 Jan 2025 04:07:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50940) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tTHAZ-0005fh-2N for 75192@debbugs.gnu.org; Thu, 02 Jan 2025 04:07:09 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTHAT-0004Do-MB; Thu, 02 Jan 2025 04:07:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4kmcE21YbeG4E0u+VXOtoVgLdn4yIBxeQfPRjTxWmQo=; b=iN0JPviIdrRb nsr7NrCpDpseaP3JpsSPCsomAXeew3IwKoSKjVcftOfS9TPWqTz9eIKXaSuJmTgfb28/ess/pJszO B3uHP9ZrmEpminVUrSwFbzT7jww4T0fkEM0l5FVn4iOuktOUyEaWug5kapYJ12bMEk1dDvp/PT/HE bqBHbfkDBV/xCOokJg+fy++H+pi4I3NUPorYz5RRkYmPruLHqhZHeNaIRVXaztBDDZ7En86csczJQ 1llY6wu2So+uP1CpV5Lf67G78+6U5ehYaIGUq/uEqHKfSKeJpVEcNy84t51K4jWIp+HxA3cEVRKLR 5AWkPvFygiBttWvsS3lC3A==; In-Reply-To: (message from Stefan Kangas on Thu, 2 Jan 2025 02:41:12 -0600) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298154 Archived-At: > From: Stefan Kangas > Date: Thu, 2 Jan 2025 02:41:12 -0600 > Cc: wkirschbaum@gmail.com, 75192@debbugs.gnu.org, casouri@gmail.com > > Eli Zaretskii writes: > > >> From: Stefan Kangas > >> Date: Thu, 2 Jan 2025 01:45:22 -0600 > >> Cc: Eli Zaretskii , Yuan Fu > >> > >> Wilhelm Kirschbaum writes: > >> > >> > This updates heex-ts-mode to use font-lock-string-face to be consistent > >> > with html-ts-mode on attribute values. > >> > >> Should we install this change on master or emacs-30? Eli, Yuan, WDYT? > > > > Are we all in agreement with the change itself? Why should an > > attribute be highlighted as a string? > > I'm not familiar with HEEx and can't share a useful opinion, but FWIW, I > simply noted that the code directly above the change said > > :feature 'heex-string > > which is why I assumed that using a string face should make sense. So we think that the current face is just a typo?