From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eduard Wiebe Newsgroups: gmane.emacs.devel Subject: Re: patch: write-file to arbitrary target directory Date: Sun, 18 Nov 2007 00:22:12 +0100 Message-ID: <86sl34a257.fsf@nirvana.pusto.de> References: <86r6ip7k4x.fsf@nirvana.pusto.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1195338256 4767 80.91.229.12 (17 Nov 2007 22:24:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 17 Nov 2007 22:24:16 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 17 23:24:21 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ItW5N-00053a-8s for ged-emacs-devel@m.gmane.org; Sat, 17 Nov 2007 23:24:21 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ItW59-0003wU-Up for ged-emacs-devel@m.gmane.org; Sat, 17 Nov 2007 17:24:07 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ItW56-0003vi-Cb for emacs-devel@gnu.org; Sat, 17 Nov 2007 17:24:04 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ItW51-0003vD-0w for emacs-devel@gnu.org; Sat, 17 Nov 2007 17:24:03 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ItW50-0003vA-Re for emacs-devel@gnu.org; Sat, 17 Nov 2007 17:23:58 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1ItW50-0004Vg-6c for emacs-devel@gnu.org; Sat, 17 Nov 2007 17:23:58 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1ItW4d-0008Hc-FY for emacs-devel@gnu.org; Sat, 17 Nov 2007 22:23:35 +0000 Original-Received: from p57b420fe.dip0.t-ipconnect.de ([87.180.32.254]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 17 Nov 2007 22:23:35 +0000 Original-Received: from usenet by p57b420fe.dip0.t-ipconnect.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 17 Nov 2007 22:23:35 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 37 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: p57b420fe.dip0.t-ipconnect.de User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (berkeley-unix) Cancel-Lock: sha1:rIg9IDI1wjlN9yDSSxSmEodDAFg= X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:83476 Archived-At: Richard Stallman writes: > The change looks useful, but there may be a problem. > > ! (let ((dir (file-name-directory (buffer-name))) > ! (file (file-name-nondirectory (buffer-name)))) > > DIR will nearly always be nil, because buffer names normally > do not include directory parts. Right. With 'ido' package user can create buffers with arbitrary names. > Thus, not using default-directory here > > ! (read-file-name "Write file: " > ! dir (expand-file-name file dir) nil file))) > > seems like a bug. I am not sure. > What is the aim of that particular change? Consider the case above, buffer has directory parts in name. By calling 'write-file' i expect a proposal of directory name with these directory parts of buffer name. And if DIR is nil, read-file-name use 'default-directory' anyway. (If i am not mistaken.) > Aside from that, it needs changes in the manual (maybe in more than > one place). I try to identify these. -- Eduard Wiebe