From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#52286: 28.0.90; [PATCH] Be consistent in naming of separators in context menu Date: Sat, 15 Jan 2022 20:57:39 +0200 Organization: LINKOV.NET Message-ID: <86sfto25ek.fsf@mail.linkov.net> References: <7a7d6b5c-ff5e-3d55-bef4-8ce8e163abdb@gmail.com> <8335n75z4a.fsf@gnu.org> <3788dcca-c2bd-99b2-b54d-463e12cd52c0@gmail.com> <835ys349p2.fsf@gnu.org> <8335n53nai.fsf@gnu.org> <6faca77f-d732-d13e-2689-76e1e0943368@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10779"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 52286@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 15 20:00:49 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8oID-0002iM-96 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jan 2022 20:00:49 +0100 Original-Received: from localhost ([::1]:34670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8oIC-0001gY-6Y for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jan 2022 14:00:48 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8oHS-0001gD-VT for bug-gnu-emacs@gnu.org; Sat, 15 Jan 2022 14:00:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48848) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8oHS-0001MN-Jq for bug-gnu-emacs@gnu.org; Sat, 15 Jan 2022 14:00:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n8oHS-0004fu-9y for bug-gnu-emacs@gnu.org; Sat, 15 Jan 2022 14:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jan 2022 19:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52286 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52286-submit@debbugs.gnu.org id=B52286.164227319417932 (code B ref 52286); Sat, 15 Jan 2022 19:00:02 +0000 Original-Received: (at 52286) by debbugs.gnu.org; 15 Jan 2022 18:59:54 +0000 Original-Received: from localhost ([127.0.0.1]:41751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8oHK-0004fA-E9 for submit@debbugs.gnu.org; Sat, 15 Jan 2022 13:59:54 -0500 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:58217) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8oHH-0004ep-UR for 52286@debbugs.gnu.org; Sat, 15 Jan 2022 13:59:53 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 65754E0002; Sat, 15 Jan 2022 18:59:43 +0000 (UTC) In-Reply-To: <6faca77f-d732-d13e-2689-76e1e0943368@gmail.com> (Jim Porter's message of "Sat, 11 Dec 2021 12:52:16 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224329 Archived-At: > It's not just for `elisp-mode'; any mode (or other third-party code) may > want to insert context menu items in a certain spot. `middle-separator' > follows the naming convention I recommend, but a hypothetical mode might > want to insert a new item just after the separator for the Undo > section. However, that's currently named `separator-undo' on master, so it > can be confusing to remember the difference in naming between these two > cases: > > (define-key-after menu [my-separator] menu-bar-separator > 'middle-separator) > > (define-key-after menu [my-separator] menu-bar-separator > 'separator-undo) If it's too late to push this to the release branch, then this definitely can't be done after the release. So probably this bug report should be closed? Meanwhile, I noticed another inconsistency where context menus for some modes are named with the -mode suffix, and some without it. With `-mode': lisp/help-mode.el (defun help-mode-context-menu (menu click) lisp/textmodes/text-mode.el (defun text-mode-context-menu (menu click) Without `-mode': lisp/progmodes/prog-mode.el (defun prog-context-menu (menu click) lisp/progmodes/elisp-mode.el (defun elisp-context-menu (menu click) Maybe it's too late to fix this inconsistency too?