From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#57400: 29.0.50; Support sending patches from VC directly Date: Mon, 10 Oct 2022 22:03:11 +0300 Organization: LINKOV.NET Message-ID: <86sfjvqz68.fsf@mail.linkov.net> References: <84v8qgn1z9.fsf@iki.fi> <87h71zo3p8.fsf@posteo.net> <87sfljmgwz.fsf@posteo.net> <87y1twvima.fsf@posteo.net> <84sfk2p846.fsf@iki.fi> <87h70i9ntt.fsf@posteo.net> <87edvl6vbj.fsf@gmail.com> <8735c1nn3y.fsf@posteo.net> <877d1d6rcy.fsf@gmail.com> <867d1cjc8w.fsf@mail.linkov.net> <87o7unkggk.fsf@posteo.net> <86edvids93.fsf@mail.linkov.net> <87zge52nx0.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13778"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Robert Pluim , 57400@debbugs.gnu.org, Antoine Kalmbach To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 10 21:27:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohyQg-0003T1-G2 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Oct 2022 21:27:10 +0200 Original-Received: from localhost ([::1]:45090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohyQf-0007XB-27 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Oct 2022 15:27:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55130) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohy6E-0003jf-PI for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2022 15:06:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50933) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohy6E-0001T0-Gh for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2022 15:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ohy6E-0003bi-Bi for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2022 15:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Oct 2022 19:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57400 X-GNU-PR-Package: emacs Original-Received: via spool by 57400-submit@debbugs.gnu.org id=B57400.166542872613815 (code B ref 57400); Mon, 10 Oct 2022 19:06:02 +0000 Original-Received: (at 57400) by debbugs.gnu.org; 10 Oct 2022 19:05:26 +0000 Original-Received: from localhost ([127.0.0.1]:50010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohy5e-0003ak-80 for submit@debbugs.gnu.org; Mon, 10 Oct 2022 15:05:26 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:57927) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohy5c-0003aL-Vr for 57400@debbugs.gnu.org; Mon, 10 Oct 2022 15:05:25 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 525C5FF807; Mon, 10 Oct 2022 19:05:15 +0000 (UTC) In-Reply-To: <87zge52nx0.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 09 Oct 2022 12:15:39 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245044 Archived-At: > Again, regarding `crm-separator' I don't know if this is a value that > people change or not (perhaps it should be changed to a defconst). At least, it's not defcustom, so it's not intended for user customization. > I can also imagine that the initial input outside of a log buffer ought > to just be the last commit. Depends on whether this is one of the most popular workflows. >> Additional question: shouldn't the behavior of >> vc-prepare-patches-separately=nil be equivalent to >> vc-prepare-patches-separately=t when only one revision is given? Both >> cases create just one mail. So when vc-prepare-patches-separately is >> nil, could it extract the subject from the single revision? Or maybe >> vc-prepare-patches-separately should support a new customization value >> for this? > > Yes, but the formatting is different. In the one case you attach a > patch to a regular message, while in the other case the message is > prepared in such a way that (at least when using Git) the entire message > is a valid patch, where we can use "git am". Hmm, I tried both variants, and still not sure which is better for the 1-patch case. However, what I definitely suggest to do is to get rid of recursive-edit, that also Robert noticed on emacs-devel. recursive-edit is too fragile for modal editing, because such commands as keyboard-escape-quit can easily break it. Without recursive-edit you can just create all mail buffers at once. Then after sending one mail, its buffer gets buried, and the next mail buffer will be shown instead, etc.