From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68842: 29.2; implicit declaration of function 'XOpenDisplay' Date: Wed, 31 Jan 2024 19:26:03 +0200 Message-ID: <86sf2d1kk4.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29090"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68842@debbugs.gnu.org To: Ulrich =?UTF-8?Q?M=C3=BCller?= , Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 31 18:27:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rVEMn-0007Hn-4K for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 31 Jan 2024 18:27:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rVEMR-0006jH-4c; Wed, 31 Jan 2024 12:26:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVEMP-0006j4-AE for bug-gnu-emacs@gnu.org; Wed, 31 Jan 2024 12:26:53 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rVEMP-0001qe-1w for bug-gnu-emacs@gnu.org; Wed, 31 Jan 2024 12:26:53 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rVEMY-0005oi-7r for bug-gnu-emacs@gnu.org; Wed, 31 Jan 2024 12:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 31 Jan 2024 17:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68842 X-GNU-PR-Package: emacs Original-Received: via spool by 68842-submit@debbugs.gnu.org id=B68842.170672198522313 (code B ref 68842); Wed, 31 Jan 2024 17:27:02 +0000 Original-Received: (at 68842) by debbugs.gnu.org; 31 Jan 2024 17:26:25 +0000 Original-Received: from localhost ([127.0.0.1]:39015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVELx-0005np-0y for submit@debbugs.gnu.org; Wed, 31 Jan 2024 12:26:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVELu-0005nd-RU for 68842@debbugs.gnu.org; Wed, 31 Jan 2024 12:26:23 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVELf-0001aW-F1; Wed, 31 Jan 2024 12:26:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Uyln/ocxtgaHzJpUvRFAxzLmTh108QeZ8x6sdoARZCs=; b=BGxIRqbCWV05QfO8MrFx M7pkf5tmHdsfVYpp1OF0fVXWTAAVzevfwy+WNBWJWT6Q7+0Bli57YOukpJjb21NUTUCMgBiS8xBTk 8N/5fdf+m3RlwpGXyYesb9mRWD86fp6I7q7cBmMNLMDczJ5FqEPSaoTS/Hi0qBDPivmrRukLEKl/o JfBNbfiwn3Y/1xcAgtNNVJ5aNkxNwNYP9JyeMWY/S2S0LBhRxelWcsn5tX+c4EJVpnxeXFOs7dueb HQdoy86g8XNIfl54ntq/UJzt/P7AAqpnUF9CEMFomqDvTB8ukbAxldrA0oqxdKF6sKEalFZNlZfOB NLkgqUJ0v3fOrQ==; In-Reply-To: (message from Ulrich =?UTF-8?Q?M=C3=BCller?= on Wed, 31 Jan 2024 09:03:29 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279236 Archived-At: > From: Ulrich Müller > Date: Wed, 31 Jan 2024 09:03:29 +0100 > > configure warns about an implicit function declaration for XOpenDisplay, > which in turn triggers a QA warning in Gentoo's package manager. > > The relevant snippet from configure.log is: > > configure:14158: checking whether X on GNU/Linux needs -b to link > configure:14175: x86_64-pc-linux-gnu-gcc -o conftest -march=native -ggdb -O2 -pipe -Wl,-O1 -Wl,--as-needed conftest.c -lX11 >&5 > conftest.c: In function 'main': > conftest.c:125:1: warning: implicit declaration of function 'XOpenDisplay' [-Wimplicit-function-declaration] > 125 | XOpenDisplay ("foo"); > | ^~~~~~~~~~~~ > configure:14175: $? = 0 > configure:14223: result: no > > Attached patch fixes the problem for me. Is it OK to merge it to the > emacs-29 branch? (In master, the test in question was removed altogether > by commit 6c1413d5ef0d1fea639b0d8c83a0c0065d99359b.) Po Lu, any comments to the patch? I don't mind installing this on emacs-29, if it's TRT, but the chances for us to have another Emacs 29.x release are slim at best at this point. So I wonder whether you should bother.