From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68559: [PATCH] Improve Python shell completion Date: Thu, 08 Feb 2024 14:13:30 +0200 Message-ID: <86sf23w3v9.fsf@gnu.org> References: <83zfx39mcy.fsf@gnu.org> <87a5og8m7t.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10223"; mail-complaints-to="usenet@ciao.gmane.io" Cc: liuhui1610@gmail.com, 68559@debbugs.gnu.org To: kobarity Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 08 13:14:03 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rY3I3-0002Tz-KM for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Feb 2024 13:14:03 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rY3Hp-0001wj-3w; Thu, 08 Feb 2024 07:13:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rY3Ho-0001wY-5v for bug-gnu-emacs@gnu.org; Thu, 08 Feb 2024 07:13:48 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rY3Hn-0005JX-Tr for bug-gnu-emacs@gnu.org; Thu, 08 Feb 2024 07:13:47 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rY3I2-0002ii-7Y for bug-gnu-emacs@gnu.org; Thu, 08 Feb 2024 07:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Feb 2024 12:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68559 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68559-submit@debbugs.gnu.org id=B68559.170739443410426 (code B ref 68559); Thu, 08 Feb 2024 12:14:02 +0000 Original-Received: (at 68559) by debbugs.gnu.org; 8 Feb 2024 12:13:54 +0000 Original-Received: from localhost ([127.0.0.1]:59297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rY3Hu-0002i6-3O for submit@debbugs.gnu.org; Thu, 08 Feb 2024 07:13:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rY3Hs-0002ht-7x for 68559@debbugs.gnu.org; Thu, 08 Feb 2024 07:13:52 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rY3HY-0005IA-Iq; Thu, 08 Feb 2024 07:13:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=TKL0dhTK8cJ8X8i4OZr14uAbQP8fhlzDnXOTaOSydn4=; b=GKiV5GXy8pVTdBGqyVuq yu9dTteVL9l/98dHaBkXaejtneqeGMSAjZrYftImTHAasHI38A8navgkzIKQqzK30kN9AD/nlYfrB UQtHCFLvdZKWVLNhGpcP34FN88HQvINhIAIa8N1eUtvgW+eDfcmv9nurGMRGZNvCaYw8rbMKW39Mm +90FOzOe9FKaLfM1+8dbcNCbtbO/1Yj6WWT6tNKHPnTY+45du7jq/Eyt1sQecPW9trJmSRMLS5K/d eHlXvkwqllZoumPDGrpqtEFUpsmK8ZqgRo6B1z8omVJNeXYa4UFX5r15vwkX4HcFpnIH6t19uCDDA rsMy8fBLrcgSbA==; In-Reply-To: (message from kobarity on Thu, 08 Feb 2024 00:19:55 +0900) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279624 Archived-At: > Date: Thu, 08 Feb 2024 00:19:55 +0900 > From: kobarity > Cc: Eli Zaretskii , > 68559@debbugs.gnu.org > > Liu Hui wrote: > > On Tue, Feb 6, 2024 at 11:12 PM kobarity wrote: > > > > > Sorry, I noticed one more thing. As written in the comments below, it > > > would be better to use `line-beginning-position' and > > > `line-end-position' instead of `pos-bol' and `pos-eol'. > > > > > > ;; This is a GNU ELPA :core package. Avoid functionality that is not > > > ;; compatible with the version of Emacs recorded above. > > > > Thanks for pointing it out! `pos-bol' was used because it can ignore > > the prompt in `python-shell--get-multiline-input'. Fortunately, I find > > `pos-bol' and `pos-eol' are available in the compat package since > > 29.1.1.0, so it should be enough to upgrade the compat version in > > Package-Requires. I have updated the attached patch. > > I see. The patch looks good to me. I appreciate your efforts! Thanks, I installed it on the master branch. What about the other patch, one you posted in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68559#46 Does that one need to be installed as well, or is it included in the one I just installed?