From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68272: [PATCH] Fix -1 leaking from C to lisp in 'read-event' etc. Date: Tue, 05 Mar 2024 15:10:39 +0200 Message-ID: <86sf14lt80.fsf@gnu.org> References: <46480759b6d89b5a4864e8ee1b986817366a56e5.camel@timruffing.de> <83wmsmucuo.fsf@gnu.org> <1b3fa12138838a3fe5643a9e76a65d32a677e34d.camel@timruffing.de> <33de23a45d00e23ddfebb24d16db95d638ac96f1.camel@timruffing.de> <933c41e932327b6c149706ca251c18046d9ffb8b.camel@timruffing.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17686"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68272@debbugs.gnu.org, monnier@iro.umontreal.ca To: Tim Ruffing Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 05 14:12:03 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rhUaP-0004Nm-K8 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Mar 2024 14:12:01 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rhUZy-0005cx-Ep; Tue, 05 Mar 2024 08:11:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhUZw-0005cR-Oh for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2024 08:11:32 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rhUZw-0005wM-FO for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2024 08:11:32 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rhUaQ-0000Yf-Ga for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2024 08:12:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Mar 2024 13:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68272 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68272-submit@debbugs.gnu.org id=B68272.17096442902102 (code B ref 68272); Tue, 05 Mar 2024 13:12:02 +0000 Original-Received: (at 68272) by debbugs.gnu.org; 5 Mar 2024 13:11:30 +0000 Original-Received: from localhost ([127.0.0.1]:46947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhUZu-0000Xq-An for submit@debbugs.gnu.org; Tue, 05 Mar 2024 08:11:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhUZr-0000Xa-Ju for 68272@debbugs.gnu.org; Tue, 05 Mar 2024 08:11:28 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhUZH-0005ot-2k; Tue, 05 Mar 2024 08:10:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=/Mj4NZacVzmJMPvHlJfye8jYyJpEnQ/YJnRJxFPDt0M=; b=e7NgDmxpWhso393/TeVh GHWQcTC4v4hRHwvZz6mu7ETf/IxqmSs7wnf8/8sBSdv9Qpkpb/5ds6+GvgnlEbzGyw1fcmidf9To+ vG7/0sky9Er6Vska3d3dx54Ws0zFQqH2b7HVMfYuh/GxpwrwcNfjJrP6rsL4YGp+N6LqFo+hNZ5+Q OSXvoQtLMyOVdIPQvyluo7W4RVnk2mUdeNRnnVTN/kPzyqnDSaxnNnurLTUfOj4XqmSAAGCDEVHB5 arhqCMvu55T+6gJHErl7Pn3aVKqYVqlXBxnASeES9YZcOaupDF19vicXfudfWyD2T71czQ7Uk2wOf Zfqo6A8WFmk7rQ==; In-Reply-To: <933c41e932327b6c149706ca251c18046d9ffb8b.camel@timruffing.de> (message from Tim Ruffing on Mon, 04 Mar 2024 19:42:09 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281050 Archived-At: > From: Tim Ruffing > Cc: Eli Zaretskii , 68272@debbugs.gnu.org > Date: Mon, 04 Mar 2024 19:42:09 +0100 > > Hi, this is an updated patch set. > > Changes to the previous revision: > * Instead of changing requeued_events_pending_p, it's renamed to > requeued_command_events_pending_p, and I've fixed the outdated > comment that had misled me.  Then a new requeued_events_pending_p > with different semantics is added and used in following commits. > This addresses one of Eli's comments, and should make sure that > existing callers of requeued_events_pending_p are not affected by > the patch. > * I've added a large comment to src/macro.c as an attempt to explain > how we handle the end of a keyboard macro. > * I've improved the commit message of (now) 6be0f5f.  Thanks, but what about the comments in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68272#11 ? IOW, what about callers that actually _want_ to know when the macro ends prematurely?