all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tim Ruffing <crypto@timruffing.de>
Cc: 68272@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#68272: [PATCH] Fix -1 leaking from C to lisp in 'read-event' etc.
Date: Tue, 05 Mar 2024 15:10:39 +0200	[thread overview]
Message-ID: <86sf14lt80.fsf@gnu.org> (raw)
In-Reply-To: <933c41e932327b6c149706ca251c18046d9ffb8b.camel@timruffing.de> (message from Tim Ruffing on Mon, 04 Mar 2024 19:42:09 +0100)

> From: Tim Ruffing <crypto@timruffing.de>
> Cc: Eli Zaretskii <eliz@gnu.org>, 68272@debbugs.gnu.org
> Date: Mon, 04 Mar 2024 19:42:09 +0100
> 
> Hi, this is an updated patch set.
> 
> Changes to the previous revision:
>  * Instead of changing requeued_events_pending_p, it's renamed to
>    requeued_command_events_pending_p, and I've fixed the outdated
>    comment that had misled me.  Then a new requeued_events_pending_p
>    with different semantics is added and used in following commits.
>    This addresses one of Eli's comments, and should make sure that
>    existing callers of requeued_events_pending_p are not affected by
>    the patch.
>  * I've added a large comment to src/macro.c as an attempt to explain
>    how we handle the end of a keyboard macro.
>  * I've improved the commit message of (now) 6be0f5f. 

Thanks, but what about the comments in
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68272#11 ?

IOW, what about callers that actually _want_ to know when the macro
ends prematurely?





  reply	other threads:[~2024-03-05 13:10 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-05 21:19 bug#68272: [PATCH] Fix -1 leaking from C to lisp in 'read-event' etc Tim Ruffing
2024-01-06  7:42 ` Eli Zaretskii
2024-01-06 14:32   ` Tim Ruffing
2024-01-13  9:39     ` Eli Zaretskii
2024-01-13 17:40     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-02 18:04       ` Tim Ruffing
2024-02-06 21:04         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-01 12:14         ` Tim Ruffing
2024-03-04 18:42           ` Tim Ruffing
2024-03-05 13:10             ` Eli Zaretskii [this message]
2024-03-05 16:45             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-05 16:55               ` Eli Zaretskii
2024-03-05 17:57                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-05 18:53                   ` Eli Zaretskii
2024-03-05 19:29                     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-05 19:55                       ` Eli Zaretskii
2024-03-05 20:18                         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-06 11:46                           ` Eli Zaretskii
2024-03-09 12:33                             ` Tim Ruffing
2024-03-09 18:08                               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-09 18:37                                 ` Eli Zaretskii
2024-03-10  8:24                                   ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-10 14:48                                   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-06  9:15 ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86sf14lt80.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=68272@debbugs.gnu.org \
    --cc=crypto@timruffing.de \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.