From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Incorporate package macrostep into Emacs core Date: Mon, 18 Mar 2024 14:48:09 +0200 Message-ID: <86sf0n4sfq.fsf@gnu.org> References: <87zfvl8r4e.fsf@jeremybryant.net> <874jdspsqb.fsf@bernoul.li> <877cio8fzf.fsf@jeremybryant.net> <87y1b46vhg.fsf@jeremybryant.net> <878r336lvb.fsf@jeremybryant.net> <86y1b1p1ni.fsf@gnu.org> <87y1b0mi4b.fsf@jeremybryant.net> <8734sobkdj.fsf@jeremybryant.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35623"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org, j.j.oddie@gmail.com, stefan@marxist.se, stefankangas@gmail.com, jonas@bernoul.li To: Jeremy Bryant Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 18 13:49:05 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rmCQK-00093l-Ts for ged-emacs-devel@m.gmane-mx.org; Mon, 18 Mar 2024 13:49:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rmCPa-0005qK-AN; Mon, 18 Mar 2024 08:48:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmCPY-0005q4-Pn for emacs-devel@gnu.org; Mon, 18 Mar 2024 08:48:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmCPW-0004VM-BG; Mon, 18 Mar 2024 08:48:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XqWD8wNX1L01YhtjY3AsKhLcVyEbu8g/HpaRlDwkjv0=; b=iQblCKwVyWQ2 m8DNSk6AWzC3C4YXSlo6Nz85BZfw4mH597TWNz5NTG8B5dretzw3uGNElYREUkU47SxwR0p9MHZ5c AVurDw0lroDrlssKchcG3S6AKqARTa7SooAUyYRaKPOC5sFI/SUGzKbu1OEuynKmAJ1Nh0NoV+/vt ViV32m9++fKTfPbKIcRrPQxI0oAKTyOOggl13P2XdqEyUSkOtVW5vAUi9GC6J9LzvNLYFnOk4rCnR D7YORd598SoEtj6YeQQRn0YKQcOmr9IC/+8RN8sM6ox3F2nVuq7IvBGFxzZE5UeA5FPI3D4tmdDEs DhBBuS+H0IrF1A/MVwGbGg==; In-Reply-To: <8734sobkdj.fsf@jeremybryant.net> (message from Jeremy Bryant on Sun, 17 Mar 2024 21:48:08 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317166 Archived-At: > From: Jeremy Bryant > Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org, j.j.oddie@gmail.com, > stefan@marxist.se, stefankangas@gmail.com, jonas@bernoul.li > Date: Sun, 17 Mar 2024 21:48:08 +0000 > > Manual? > Should the documentation for macrostep be included in the Emacs Lisp > manual section Macros? Yes, I think so. Please also provide a suitable entry for NEWS. > Code? > The main file is attached for convenience, from the orphanage upstream > (https://github.com/emacsorphanage/macrostep). > Are any changes needed before this is merged into Emacs? > I volunteer to write some code towards this, please let me know. Please add :version tags to all the defcustom's and defface's. > (define-obsolete-variable-alias 'macrostep-mode-keymap 'macrostep-mode-map "2023") > (define-obsolete-variable-alias 'macrostep-keymap 'macrostep-mode-map "2022") The years there should be changed to Emacs versions, I think. > (defvar macrostep-mode-map > (let ((map (make-sparse-keymap))) > (define-key map (kbd "RET") #'macrostep-expand) > (define-key map "=" #'macrostep-expand) > (define-key map "e" #'macrostep-expand) Bonus points for converting this into defvar-keymap. > ;; Local Variables: > ;; indent-tabs-mode: nil > ;; End: I think this should be deleted, as this is now the default in ELisp buffers.