From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode. Date: Sat, 13 Apr 2024 12:33:15 +0300 Message-ID: <86sezpppyc.fsf@gnu.org> References: <86r0f9ranr.fsf@gnu.org> <86mspxr9ra.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26646"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70361@debbugs.gnu.org, casouri@gmail.com To: Noah Peart Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 13 11:34:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rvZm9-0006bi-UX for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Apr 2024 11:34:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rvZlm-0006tX-Cn; Sat, 13 Apr 2024 05:33:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvZlf-0006qx-Lc for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 05:33:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rvZlf-0008Ho-Bj for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 05:33:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rvZlp-00071N-Md for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 05:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Apr 2024 09:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70361 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70361-submit@debbugs.gnu.org id=B70361.171300081826747 (code B ref 70361); Sat, 13 Apr 2024 09:34:01 +0000 Original-Received: (at 70361) by debbugs.gnu.org; 13 Apr 2024 09:33:38 +0000 Original-Received: from localhost ([127.0.0.1]:60146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvZlQ-0006x7-M5 for submit@debbugs.gnu.org; Sat, 13 Apr 2024 05:33:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvZlO-0006vl-N2 for 70361@debbugs.gnu.org; Sat, 13 Apr 2024 05:33:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvZl8-0008FQ-S1; Sat, 13 Apr 2024 05:33:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=S0FgjfWgdZd1T6MVXNQYYokwv3E9lBhPZxwL9H8tt/U=; b=GvDT1HwwY+lC zf0v9wCDJhrfm4qyIdP0v+ZhHRT8oOHjQOQ9V0lWByE2Ny/eJH3d2mF0mzapJLHJs40I9dIv1+Rhk ruuXjkrl74IyCyr5JnEi7XCM5B+fOFVezEUkHPivmpLtnNchgdpX5l3aADvllCd05Us8GMOE4+djL dS45/ohpcU86kMtjB6+hs3P+a3KxNmrG2NcNU2wLY1NOE4cx6GEctDvTvZtY1pv0r498kJyOpPcOl NKFTNtSAxUQTZLszChcSbK4CNxBCOxUrswEAhZrB9cgFa18Gj0Fk8aqbrRPFdw6/NR56iJCRi/axu Xc/+eojq0unuYlmNw+JDrQ==; In-Reply-To: (message from Noah Peart on Sat, 13 Apr 2024 00:53:45 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283196 Archived-At: > From: Noah Peart > Date: Sat, 13 Apr 2024 00:53:45 -0700 > Cc: Yuan Fu , 70361@debbugs.gnu.org > > > What problems do you see with the current approach that would require > more fine-grained user control? > > The main issue for me is removing the `error` feature from any mode > that adds it with `:override t`. I find the override font-locking is jarring - in some > Languages half the buffer can switch in and out of parse errors when you > do something as simple as removing a closing paren. Maybe we should have a user option to turn error feature on and off. Yuan, WDYT? > Also, allowing users to rearrange features at different levels seems like a bonus. Not sure about this one. We didn't have that in the traditional font-lock, did we?