From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62994: [PATCH v7] Add support for colored and styled underlines on tty frames Date: Tue, 23 Apr 2024 09:02:18 +0300 Message-ID: <86sezc4nx1.fsf@gnu.org> References: <87pm7x5mxc.fsf@kisara.moe> <87sezeitkj.fsf@kisara.moe> <87sezegra8.fsf@yahoo.com> <86bk626imf.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18966"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, 62994@debbugs.gnu.org To: Po Lu , mohkale@kisara.moe Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 23 08:03:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rz9FJ-0004fd-UX for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Apr 2024 08:03:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rz9F3-00061K-Rx; Tue, 23 Apr 2024 02:02:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rz9F2-00061C-Mf for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2024 02:02:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rz9F2-0006Wx-Bh for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2024 02:02:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rz9FI-00039I-1N for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2024 02:03:12 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Apr 2024 06:03:11 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62994 X-GNU-PR-Package: emacs Original-Received: via spool by 62994-submit@debbugs.gnu.org id=B62994.171385217011918 (code B ref 62994); Tue, 23 Apr 2024 06:03:11 +0000 Original-Received: (at 62994) by debbugs.gnu.org; 23 Apr 2024 06:02:50 +0000 Original-Received: from localhost ([127.0.0.1]:50120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rz9Et-00035m-49 for submit@debbugs.gnu.org; Tue, 23 Apr 2024 02:02:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34400) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rz9En-00034K-HJ for 62994@debbugs.gnu.org; Tue, 23 Apr 2024 02:02:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rz9ER-0006Pp-EL; Tue, 23 Apr 2024 02:02:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EFtRmp/+R+b4eycYlxZL1a61Ohrx8PeB1LLi3xPuCC4=; b=KeFrzZm11VwU 3nkQWgUvrOUdDJmWeYvEnc1UXnEcC16FEpZISv4p2JIuuP5AkQf2VQDduyVvXzP+w9k5KP8CnI2g2 3wVfdV9vpY+xFsojjcxdmWzKsGMcw3a88mzVdBtPxwPabReNijjLhvA+KyPFmgAxYUM1ABIr3rf5V pFTQp7CqLrwLXM4NcKL0L7tYo1SCsAXL2GmK6rRgBFRNQt4oGkYjRC9bzlqcVzN/ffnnL1eaJCs4w 6S4uhoHmnRMP/vKm3N8j3yKqZWN7tLxbVlFLzazfcdo356Q8cvgYzrvRefZTIooVPgM0PUkoJFfoE n5n0NtyVQ7Xz/f3whLyV/w==; In-Reply-To: (message from Po Lu on Tue, 23 Apr 2024 08:53:20 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283869 Archived-At: > From: Po Lu > Cc: Jim Porter , mohkale@kisara.moe, > 62994@debbugs.gnu.org > Date: Tue, 23 Apr 2024 08:53:20 +0800 > > Eli Zaretskii writes: > > >> Cc: 62994@debbugs.gnu.org > >> Date: Mon, 22 Apr 2024 08:44:15 +0800 > >> From: Po Lu via "Bug reports for GNU Emacs, > >> the Swiss army knife of text editors" > >> > >> > * src/xterm.c (x_draw_glyph_string): Updated to use renamed > >> > FACE_UNDERLINE_SINGLE and FACE_UNDERLINE_WAVE face_underline_type > >> > enumerations. > >> > >> This change should be accompanied by like updates to > >> *_draw_glyph_string > >> and related functions in the remaining terminal backends. > > > > I believe Jim Porter wanted to work on that. Jim, have you made any > > progress in this matter? > > > > In any case, given that implementing this for GUI displays should not > > be a problem, I don't see a reason to block this changeset until the > > GUI parts are done. Hopefully, Jim or someone else will get it ready > > soon. > > I wasn't asking that the new underline styles be ported to other > backends, but that the change to account for renamed enumerator values > be ported to the remainder of the *term.[cm] files. Without which they > will fail to compile, which goes without saying. I will not install a changeset that breaks the build, rest assured. I always build Emacs after applying patches from others, so I'd know if the build is broken. I presume Mohsin builds Emacs with his changes, so unless he only builds Emacs --without-x, I presume the changes do build? Or what am I missing?