From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68765: 30.0.50; Adding window-tool-bar package. Date: Sat, 27 Apr 2024 11:25:59 +0300 Message-ID: <86sez7w6so.fsf@gnu.org> References: <6c2e5fe5d3439f0a3696f86bd99bbb7b@finder.org> <88fb732b480d7a33ed1464d40127c3fc@finder.org> <86h6g5r9le.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24165"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, jared@finder.org, 68765@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 27 10:26:59 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s0dOd-00063o-7c for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 Apr 2024 10:26:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s0dOP-0006IE-Hj; Sat, 27 Apr 2024 04:26:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0dOO-0006I3-23 for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2024 04:26:44 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s0dON-0001Dq-Pt for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2024 04:26:43 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s0dOg-0006cU-Hr for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2024 04:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Apr 2024 08:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68765 X-GNU-PR-Package: emacs Original-Received: via spool by 68765-submit@debbugs.gnu.org id=B68765.171420639425135 (code B ref 68765); Sat, 27 Apr 2024 08:27:02 +0000 Original-Received: (at 68765) by debbugs.gnu.org; 27 Apr 2024 08:26:34 +0000 Original-Received: from localhost ([127.0.0.1]:38871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0dOC-0006Ws-Dp for submit@debbugs.gnu.org; Sat, 27 Apr 2024 04:26:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0dOA-0006VQ-9p for 68765@debbugs.gnu.org; Sat, 27 Apr 2024 04:26:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0dNl-00014b-PP; Sat, 27 Apr 2024 04:26:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=c9CFitdc9cVtlFyvwdzv0yY6EZWks/mse097Ne87nrk=; b=Tw1fZI00Yk7U hfdeJWUmvtBPnvRBvS9cI6mVty1ctdUEAmvmz3isv18zCaCeCopF8rUbatHyq5HDSHKwV3+vpylGF XuACWSSE7dBn23bXEnFatpF7EXJemzsPRMvHfNviXSFwRgdqgI+u80CYuuT9A2JN55rhy8uzw5N6L 0V8MmlLVcJS4FJVZbv9UtXglwKACdD1ryYsmM8iwtyCrmj3AaRqP/k6KNe58wP14wg13DbOoS9QqP 9S34n/wqeteEBj6tZuqBLcmtS/kaeAPE+8cAlKQ06/4X3dFzU4wtXLXVLoQlbbcun3TiKiJvV+VKP BSTa/+SNy1N6n9YZoIJAZQ==; In-Reply-To: <86h6g5r9le.fsf@gnu.org> (message from Eli Zaretskii on Sat, 13 Apr 2024 10:43:41 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284018 Archived-At: Ping! Ping! Philip and Jared, are there any issues left to resolve here, or should this be installed? > Cc: philipk@posteo.net, 68765@debbugs.gnu.org > Date: Sat, 13 Apr 2024 10:43:41 +0300 > From: Eli Zaretskii > > Ping! How should we make progress with this issue? > > > Date: Tue, 26 Mar 2024 08:33:22 -0700 > > From: Jared Finder > > Cc: 68765@debbugs.gnu.org > > > > It's been four weeks and I've seen no reply to these updated patches. > > Are you able to review? > > > > On 2024-02-26 19:02, Jared Finder wrote: > > > On 2024-02-11 12:51, Philip Kaludercic wrote: > > >> Here are a few comments from a quick skim: > > > > > > Comments addressed. New patches for 0002 and 0003 added. I also > > > addressed Eli's comments from > > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68765#10 as well. > > > > > > The following comment was not addressed: > > > > > >>> +(defun window-tool-bar-show-memory-use () > > >>> + "Pop up a window showing the memory use metrics." > > >>> + (interactive) > > >>> + (require 'time-stamp) > > >>> + (save-selected-window > > >>> + (pop-to-buffer "*WTB Memory Report*") > > >> > > >> I think you should rewrite this as > > >> > > >> (with-current-buffer (get-buffer "...") > > >> ;; ... > > >> (pop-to-buffer (current-buffer)) > > > > > > I couldn't make this change and keep the current behavior that is > > > important to me: > > > > > > 1. The window with focus should not change. > > > 2. The buffer should get scrolled to the bottom to displayed the newly > > > inserted text. > > > > > > -- MJF > > > > > >