From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#70576: [PATCH] `repeat-echo-message-string': support repeat keymap "hints" Date: Thu, 02 May 2024 19:16:06 +0300 Organization: LINKOV.NET Message-ID: <86sez06w59.fsf@mail.linkov.net> References: <45C35B69-6DA8-4212-BD87-50B2A3959A86@gmail.com> <86h6fo3e7e.fsf@mail.linkov.net> <86cyqaezhc.fsf@mail.linkov.net> <86ttjle92p.fsf@mail.linkov.net> <86zft8676h.fsf@mail.linkov.net> <86r0ekn0o0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33001"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 70576@debbugs.gnu.org, jdtsmith@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 02 18:19:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s2Z9J-0008Iv-88 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 May 2024 18:19:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2Z8v-0000dZ-7H; Thu, 02 May 2024 12:18:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2Z8q-0000cW-UZ for bug-gnu-emacs@gnu.org; Thu, 02 May 2024 12:18:41 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s2Z8q-0006v0-N5 for bug-gnu-emacs@gnu.org; Thu, 02 May 2024 12:18:40 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s2Z9C-0007rQ-7a for bug-gnu-emacs@gnu.org; Thu, 02 May 2024 12:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 May 2024 16:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70576 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70576-submit@debbugs.gnu.org id=B70576.171466668330207 (code B ref 70576); Thu, 02 May 2024 16:19:02 +0000 Original-Received: (at 70576) by debbugs.gnu.org; 2 May 2024 16:18:03 +0000 Original-Received: from localhost ([127.0.0.1]:44665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2Z8F-0007r9-0t for submit@debbugs.gnu.org; Thu, 02 May 2024 12:18:03 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:43959) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2Z8C-0007qk-U5 for 70576@debbugs.gnu.org; Thu, 02 May 2024 12:18:01 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 7CB0140007; Thu, 2 May 2024 16:17:31 +0000 (UTC) In-Reply-To: <86r0ekn0o0.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 02 May 2024 10:16:47 +0300") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284334 Archived-At: >> >>> (defvar-keymap expreg-repeat-map >> >>> :doc "Repeat map for `expreg' actions." >> >>> :repeat '(:hints ((expreg-expand . "expand") (expreg-contract . "contract"))) >> >>> "\\" 'expreg-expand >> >>> "|" 'expreg-contract) >> >> >> >> If a hint is missing for a command, it should just have its key mentioned. >> >> It looks like your idea would require changes to defvar-keymap. Do you >> >> want to propose a patch? We'd need some way to pass the hints in; perhaps >> >> the macro could set a property on the command symbol as you initially >> >> proposed. >> > >> > Alright, let's add this to defvar-keymap. Please try the following patch. >> >> Thanks for the feature request. This is pushed now. > > Thanks, but please also update the ELisp manual and add an entry to > NEWS about this change. A NEWS entry was already added with "---" since I didn't expect that such a small feature that is not used anywhere needs to grow the size of the manual.