all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 70576@debbugs.gnu.org, jdtsmith@gmail.com
Subject: bug#70576: [PATCH] `repeat-echo-message-string': support repeat keymap "hints"
Date: Thu, 02 May 2024 19:16:06 +0300	[thread overview]
Message-ID: <86sez06w59.fsf@mail.linkov.net> (raw)
In-Reply-To: <86r0ekn0o0.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 02 May 2024 10:16:47 +0300")

>> >>> (defvar-keymap expreg-repeat-map
>> >>>    :doc "Repeat map for `expreg' actions."
>> >>>    :repeat '(:hints ((expreg-expand . "expand") (expreg-contract . "contract")))
>> >>>    "\\" 'expreg-expand
>> >>>    "|"  'expreg-contract)
>> >>
>> >> If a hint is missing for a command, it should just have its key mentioned.
>> >> It looks like your idea would require changes to defvar-keymap.  Do you
>> >> want to propose a patch?  We'd need some way to pass the hints in; perhaps
>> >> the macro could set a property on the command symbol as you initially
>> >> proposed.
>> >
>> > Alright, let's add this to defvar-keymap.  Please try the following patch.
>>
>> Thanks for the feature request.  This is pushed now.
>
> Thanks, but please also update the ELisp manual and add an entry to
> NEWS about this change.

A NEWS entry was already added with "---" since I didn't expect that
such a small feature that is not used anywhere needs to grow
the size of the manual.





  parent reply	other threads:[~2024-05-02 16:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-25 22:31 bug#70576: [PATCH] `repeat-echo-message-string': support repeat keymap "hints" JD Smith
2024-04-26  6:06 ` Juri Linkov
2024-04-26 14:37   ` JD Smith
2024-04-28  6:58     ` Juri Linkov
2024-04-28 12:45       ` JD Smith
2024-04-28 16:38         ` Juri Linkov
2024-05-02  6:48           ` Juri Linkov
2024-05-02  7:16             ` Eli Zaretskii
2024-05-02 11:47               ` JD Smith
2024-05-02 16:16               ` Juri Linkov [this message]
2024-05-02 18:14                 ` Eli Zaretskii
2024-05-03  6:23                   ` Juri Linkov
2024-05-03  7:15                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86sez06w59.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=70576@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=jdtsmith@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.