From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70929: 30.0.50; eglot--apply-text-edits prevents point adjustment Date: Tue, 14 May 2024 09:23:42 +0300 Message-ID: <86seykx66p.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34591"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70929@debbugs.gnu.org To: Troy Brown , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 14 08:25:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s6lbE-0008qL-7x for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 May 2024 08:25:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s6lay-0003v2-ET; Tue, 14 May 2024 02:25:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6law-0003uH-6n for bug-gnu-emacs@gnu.org; Tue, 14 May 2024 02:25:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s6lav-00047U-Sb for bug-gnu-emacs@gnu.org; Tue, 14 May 2024 02:25:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s6law-0000R2-Hx for bug-gnu-emacs@gnu.org; Tue, 14 May 2024 02:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 May 2024 06:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70929 X-GNU-PR-Package: emacs Original-Received: via spool by 70929-submit@debbugs.gnu.org id=B70929.17156678431641 (code B ref 70929); Tue, 14 May 2024 06:25:02 +0000 Original-Received: (at 70929) by debbugs.gnu.org; 14 May 2024 06:24:03 +0000 Original-Received: from localhost ([127.0.0.1]:37346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6lZz-0000QP-1k for submit@debbugs.gnu.org; Tue, 14 May 2024 02:24:03 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6lZu-0000Q0-3T for 70929@debbugs.gnu.org; Tue, 14 May 2024 02:24:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6lZl-000423-8U; Tue, 14 May 2024 02:23:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=BOACMtfcXM9xqrqvJBaAW9bXlc8sJR3NaAQTUBJ9Q5A=; b=ME13D6KysyJDaUj+7Fza s9E6tR02y9nW79UfJOkNsiYsslQg5gN0/zZmzKHuXqWbiy0TnlqwNQe0brkDEfwokJeIFssnU0xeq qHurWw0zn965PX3NbOzmBnRBfD9Vwy5rSsAuvqEps9FSeJGH1fsb+QUiuH+11KF4lZkJ7CcfkwMN1 rZyTPX4EnhowuvhMi5asLYQMQ0p/9VZznao6Nvqoo9g9+c+8PanSTvZhzFoABG54B+t80Cugv6YhZ ya5kVZT2HnS5Vk/Y5xeWW08LT2KcLHfb8BCkpmBDyBMvGwSKBfxNMXEPh4DbMh+Cmz8sEHnuLetox Pha0JOLaesmceA==; In-Reply-To: (message from Troy Brown on Mon, 13 May 2024 22:15:07 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284996 Archived-At: > From: Troy Brown > Date: Mon, 13 May 2024 22:15:07 -0400 > > Language Servers may use onTypeFormatting to provide indentation for a > buffer. When this happens, the language server will indicate a > newline trigger character (in the DocumentOnTypeFormattingOptions). > In the Emacs buffer, after hitting RET, point is moved to the next > line and a textDocument/onTypeFormatting request is sent from Eglot to > the server. The server responds back with the corresponding spacing > prefix for the line in newText of the TextEdit response. However, > when Eglot applies the text edit to insert this spacing, via > eglot--apply-text-edits, it uses save-excursion, and this prevents the > point from being pushed to the end of the inserted spacing. It would > seem that save-excursion should be avoided when applying text edits. > This issue has been observed with the Ada Language Server. Thanks. João, any comments or suggestions?