all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ergus <spacibba@aol.com>
Cc: casouri@gmail.com, 71070@debbugs.gnu.org
Subject: bug#71070: 30.0.50; c++-ts-mode namespace wrong fontification.
Date: Mon, 20 May 2024 14:11:21 +0300	[thread overview]
Message-ID: <86seycagbq.fsf@gnu.org> (raw)
In-Reply-To: <d7akmu62i2mumejjztwdtgmvktdijbhi4c7fbha5ysb6inagzd@dcxxxncbgnd6> (message from Ergus on Sun, 19 May 2024 23:36:41 +0200)

> Date: Sun, 19 May 2024 23:36:41 +0200
> From: Ergus <spacibba@aol.com>
> Cc: casouri@gmail.com, 71070@debbugs.gnu.org
> 
> On Sun, May 19, 2024 at 10:13:45PM GMT, Eli Zaretskii wrote:
> >No one said that what c++-mode does is necessarily correct.  maybe it
> >is, maybe it isn't.
> >
> >How do other C++ IDEs fontify namespace names?
> 
> Hi Eli:
> 
> Every editor-ide has its own approach for this. But emacs has it own
> flavor and the ts-* intention was to keep it as close as possible to the
> status-quo; that's why I am reporting it here.
> 
> There are many details missing in the c/c++-ts-mode compared to
> c-mode... but I understand that some of them are WIP while others are
> just too complex to port.

I understand all that, but still: can you (or someone else) answer my
question about the accepted practices of IDEs in this matter: do they
highlight the namespace identifiers differently than other
identifiers, or do they use the same highlighting?

It is IMO important to know what are the accepted practices, to deal
with this issue in a proper perspective.

> My main concern here is that this seemed like a simple issue considering
> that treesitter recognizes the namespace correctly. But the Yuan's fix
> didn't work; so maybe there is a detail we are missing here, or that
> needs extra documentation? Or in the worst case some detail/issue broken
> in the ts api?

I don't know.  In particular, I don't know what specific aspects of
this did Yuan try to fix.  Yuan is CC'ed and will hopefully chime in
and answer these questions.  Meanwhile we should make up our minds
regarding the desired behavior, which is mostly independent of what
Yuan tried to do and even of what c++-mode does.

Thanks.





  reply	other threads:[~2024-05-20 11:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87h6et6550.fsf.ref@aol.com>
2024-05-19 18:14 ` bug#71070: 30.0.50; c++-ts-mode namespace wrong fontification Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-19 18:36   ` Eli Zaretskii
2024-05-19 19:00     ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-19 19:13       ` Eli Zaretskii
2024-05-19 21:36         ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-20 11:11           ` Eli Zaretskii [this message]
2024-05-21 23:27             ` Dmitry Gutov
2024-05-22  6:23               ` Yuan Fu
2024-05-22 12:17               ` Eli Zaretskii
2024-05-22 13:33                 ` Dmitry Gutov
2024-06-06  5:28                   ` Yuan Fu
2024-06-06 20:16                     ` Dmitry Gutov
2024-06-15  8:34                       ` Eli Zaretskii
2024-06-19  6:27                         ` Yuan Fu
2024-06-19 11:52                           ` Eli Zaretskii
2024-06-21  1:53                             ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86seycagbq.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=71070@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=spacibba@aol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.