From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#69941: 30.0.50; Faulty fontification of radio button widgets Date: Sat, 08 Jun 2024 14:50:57 +0300 Message-ID: <86sexnd55q.fsf@gnu.org> References: <87h6gynx49.fsf@rub.de> <87o79c8n60.fsf@gmx.net> <87zfst4zuh.fsf@rub.de> <87v83h4y31.fsf@rub.de> <86zfsez5w3.fsf@gnu.org> <874jam9r2o.fsf@gmx.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15200"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69941@debbugs.gnu.org To: monnier@iro.umontreal.ca, Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 08 13:51:57 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sFuc0-0003h5-7m for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Jun 2024 13:51:56 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sFubs-0001sO-Kj; Sat, 08 Jun 2024 07:51:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFubq-0001rt-JT for bug-gnu-emacs@gnu.org; Sat, 08 Jun 2024 07:51:46 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sFubq-00087u-AV for bug-gnu-emacs@gnu.org; Sat, 08 Jun 2024 07:51:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sFuc6-0007yx-13 for bug-gnu-emacs@gnu.org; Sat, 08 Jun 2024 07:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Jun 2024 11:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69941 X-GNU-PR-Package: emacs Original-Received: via spool by 69941-submit@debbugs.gnu.org id=B69941.171784748530639 (code B ref 69941); Sat, 08 Jun 2024 11:52:01 +0000 Original-Received: (at 69941) by debbugs.gnu.org; 8 Jun 2024 11:51:25 +0000 Original-Received: from localhost ([127.0.0.1]:37666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFubU-0007y7-QX for submit@debbugs.gnu.org; Sat, 08 Jun 2024 07:51:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFubS-0007xo-HW for 69941@debbugs.gnu.org; Sat, 08 Jun 2024 07:51:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFub5-00083y-HC; Sat, 08 Jun 2024 07:51:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=G1N4sOgR2hMBlxwevPwjL4MnVAMdFficHSnpzCka47Q=; b=IgG9RFwlHDNj RepoplcAWOEAWFrZZUg4cKzTQaPhpJ26Qs5VDanogWuO4HRYZmd82a6/HV9bzda6xFGBuAmTMupjJ v9kdopEaH5NYM/SARpwXxiD6pKBboZEI7KjoPZBIlQjwCJeAqcqPl45jEU70YVaUxX2xVjV2T30Au CCMFis90T3omKmXo8aKBRXY8ik5bOYvlGsDRx54uRgy4dbPtq+r2FcWjeSqH3fRYkjmxRa3soav9a Es+TiTroELy/L6OsVCztKMPgSZ8taSor18g6jHXeP6W2Bl/XqhQfWfkHcP7rh5mlILUJS4cYF7zn+ K1HC/98iRTnhLFk/9ZUGtg==; In-Reply-To: <874jam9r2o.fsf@gmx.net> (message from Stephen Berman on Sat, 25 May 2024 11:30:23 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286836 Archived-At: > From: Stephen Berman > Cc: Stefan Monnier , 69941@debbugs.gnu.org > Date: Sat, 25 May 2024 11:30:23 +0200 > > On Sat, 25 May 2024 10:51:08 +0300 Eli Zaretskii wrote: > > > Ping! Any further comments about this, or changes to install? > > I haven't been able to pursue Stefan's suggestions yet. For the use > case for which I made the patch, I find the results overall better than > without it. Nevertheless, text inserted in front of the first radio > button unintentionally getting fontified with widget-inactive face is a > clear bug, so I think the patch should not be installed; I hope I (or > someone else) can improve it. Stefan, any other comments? Should I close the bug? > >> Cc: 69941@debbugs.gnu.org > >> Date: Mon, 13 May 2024 10:19:43 -0400 > >> From: Stefan Monnier via "Bug reports for GNU Emacs, > >> the Swiss army knife of text editors" > >> > >> >> Or maybe `widget-*-add-item` should temporarily change the insertion > >> >> type of the from/to markers? > >> > What do you mean by "temporarily"? > >> > >> I think you underestimated the meaning of: > >> > >> I'm really not familiar with the widget code > >> > >> I put "really" before the "not", because I know very little about > >> that code. > >> > >> > Maybe it could be left up to the deactivation code to ensure that the > >> > radio-button-choice widget's :from and the :from of its first child > >> > coincide when deactivation (and accompanying fontification) occurs, and > >> > then reset the previous values afterwards. > >> > >> I suspect thinking in terms of "activation/deactivation" will not > >> be helpful. We should look at the code which does the insertion of text > >> (which presumably happens, among other things, upon deactivation). > >> > >> > Though that seems pretty ad hoc... > >> > >> If needed, we might be able to make it less ad-hoc by defining > >> a function for the purpose of (re)inserting text inside an > >> existing widget. > >> > >> > (and would resetting the :from affect the fontification?) > >> > >> It'd be up to that new function to make sure things work as they should. > >> > >> > >> Stefan > >> > >> > >> > >> > >> >