From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: luangruo@yahoo.com, 71477@debbugs.gnu.org
Subject: bug#71477: 30.0.50; Lock files are not deleted on Windows 98
Date: Wed, 12 Jun 2024 20:10:50 +0300 [thread overview]
Message-ID: <86sexiytlx.fsf@gnu.org> (raw)
In-Reply-To: <531dbf85-2554-43aa-bca1-db50e0bf2306@cs.ucla.edu> (message from Paul Eggert on Wed, 12 Jun 2024 09:07:52 -0700)
> Date: Wed, 12 Jun 2024 09:07:52 -0700
> Cc: 71477@debbugs.gnu.org
> From: Paul Eggert <eggert@cs.ucla.edu>
>
>
> On 2024-06-12 01:25, Eli Zaretskii wrote:
>
> > - if (! c_isdigit (dot[1]))
> > + if (! (c_isdigit (dot[1])
> > + /* Windows 9X report negative PID values. */
> > + || (dot[1] == '-' && c_isdigit (dot[2]))))
>
> Faster is "if (! c_isdigit[(dot[1] == '-') + 1])", as it avoids a
> conditional branch on most platforms.
OK.
> > - else if (0 < pid && pid <= TYPE_MAXIMUM (pid_t)
> > + else if (pid != -1 && pid <= TYPE_MAXIMUM (pid_t)
> > && (kill (pid, 0) >= 0 || errno == EPERM)
>
> This looks dubious for most systems, where 'kill' has special behavior
> when pid < -1 or pid == 0; it tests a process group. That's not the test
> we want here, since we want to check whether Emacs can be sent a signal,
> not whether any process in its process group can be sent a signal (this
> can be valid even after Emacs has exited). The code should use calls
> like kill (-2, 0) and kill (0, 0) only on platforms where we know the
> calls do not test a process group.
But on all platforms except Windows 9X we shouldn't see a negative PID
here, so what you say is purely theoretical, no?
> Even on MS Windows 98 we should check that TYPE_MINIMUM (pid_t) <= pid.
Since pid_t is typedefed as 'int', that's always true, no?
> Also, is there a special meaning for kill (0, 0) on MS Windows 98?
No. And our emulation of 'kill' fails with EPERM when called witgh
both arguments zero.
> If so, we should also check that pid != 0.
There are no processes on Windows whose PID is zero, so getting zero
here is impossible.
> Do any MS-Windows platforms support process groups, i.e., kill (-2, 0)
> operates on process group 2 rather than on an individual process with
> process ID -2? If so, these platforms should be careful too, and should
> not use kill (-2, 0) or kill (0, 0).
Windows does support process groups, but our emulation of 'kill'
pretends that each process is its own group.
> How about the attached patch instead? You can adjust the
> Microsoft-specific .h files to define VALID_PROCESS_ID appropriately for
> MS Windows 98, and for any other MS platform where kill (-2, 0) is known
> to check for just the individual process -2.
Fine with me, please install and I will followup.
Thanks.
next prev parent reply other threads:[~2024-06-12 17:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87r0d4bzut.fsf.ref@yahoo.com>
2024-06-10 15:07 ` bug#71477: 30.0.50; Lock files are not deleted on Windows 98 Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-10 17:44 ` Eli Zaretskii
[not found] ` <87ikygb6hp.fsf@yahoo.com>
2024-06-11 6:47 ` Eli Zaretskii
[not found] ` <87bk47c4cd.fsf@yahoo.com>
2024-06-11 7:56 ` Eli Zaretskii
[not found] ` <871q53c2ur.fsf@yahoo.com>
2024-06-11 8:28 ` Eli Zaretskii
[not found] ` <87jzivamzp.fsf@yahoo.com>
2024-06-11 13:03 ` Eli Zaretskii
2024-06-11 13:34 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-12 8:25 ` Eli Zaretskii
2024-06-12 16:07 ` Paul Eggert
2024-06-12 17:10 ` Eli Zaretskii [this message]
2024-06-12 17:57 ` Paul Eggert
2024-06-13 8:06 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86sexiytlx.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=71477@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.