all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Spencer Baugh <sbaugh@janestreet.com>
Cc: 72426@debbugs.gnu.org
Subject: bug#72426: 29.2.50; comint-pager doesn't affect async-shell-command
Date: Sat, 03 Aug 2024 08:48:07 +0300	[thread overview]
Message-ID: <86sevmupgo.fsf@gnu.org> (raw)
In-Reply-To: <ierjzgyrcwi.fsf@janestreet.com> (message from Spencer Baugh on Fri, 02 Aug 2024 14:35:25 -0400)

> From: Spencer Baugh <sbaugh@janestreet.com>
> Date: Fri, 02 Aug 2024 14:35:25 -0400
> 
> 
> 1. PAGER=less emacs -Q
> 2. (setq comint-pager "cat")
> 3. (async-shell-command "echo $PAGER")
> 4. Observe "less" rather than "cat".
> 
> I intended async-shell-command to also be affected when I added
> comint-pager; a patch to fix this will follow.

Thanks, I don't think this is right: comint stuff should not affect
lower-level primitives, it should only affect comint and its callers.

Lisp programs that use async-shell-command can arrange for
process-environment to have PAGER=SOMETHING as they see fit.

So I don't think we should install your patch.





  parent reply	other threads:[~2024-08-03  5:48 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-02 18:35 bug#72426: 29.2.50; comint-pager doesn't affect async-shell-command Spencer Baugh
2024-08-02 18:39 ` Spencer Baugh
2024-08-03  5:48 ` Eli Zaretskii [this message]
2024-08-03 10:47   ` Spencer Baugh
2024-08-03 15:38     ` Eli Zaretskii
2024-08-03 16:42       ` Spencer Baugh
2024-08-03 17:18         ` Eli Zaretskii
2024-08-06 15:33           ` Spencer Baugh
2024-08-06 15:46             ` Eli Zaretskii
2024-08-06 16:29               ` Jim Porter
2024-08-06 18:02                 ` Eli Zaretskii
2024-08-03 18:38       ` Jim Porter
2024-08-06 15:31         ` Spencer Baugh
2024-08-06 15:50           ` Eli Zaretskii
2024-08-06 16:42             ` Spencer Baugh
2024-08-06 18:07               ` Eli Zaretskii
2024-08-06 18:49                 ` Spencer Baugh
2024-08-06 19:07                   ` Eli Zaretskii
2024-08-06 19:23                     ` Spencer Baugh
2024-08-07  2:36                       ` Jim Porter
2024-08-07 11:51                         ` Eli Zaretskii
2024-08-07 15:05                           ` Spencer Baugh
2024-08-07 15:26                             ` Eli Zaretskii
2024-08-07 15:31                               ` Spencer Baugh
2024-08-07 16:08                                 ` Jim Porter
2024-08-07 11:18                       ` Eli Zaretskii
2024-08-07 15:09                         ` Spencer Baugh
2024-08-17  9:25                       ` Eli Zaretskii
2024-09-13  1:17       ` Dmitry Gutov
2024-09-13  6:08         ` Eli Zaretskii
2024-09-13 23:45           ` Dmitry Gutov
2024-09-14  6:27             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86sevmupgo.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=72426@debbugs.gnu.org \
    --cc=sbaugh@janestreet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.