From: Eli Zaretskii <eliz@gnu.org>
To: Pip Cet <pipcet@protonmail.com>
Cc: execvy@gmail.com, emacs-devel@gnu.org
Subject: Re: [MPS-test] scratch/igc branch (commit: 42731228d24) crashed
Date: Mon, 05 Aug 2024 21:19:51 +0300 [thread overview]
Message-ID: <86seviq1bs.fsf@gnu.org> (raw)
In-Reply-To: <87h6byvoiq.fsf@protonmail.com> (message from Pip Cet on Mon, 05 Aug 2024 18:00:00 +0000)
> Date: Mon, 05 Aug 2024 18:00:00 +0000
> From: Pip Cet <pipcet@protonmail.com>
> Cc: execvy@gmail.com, emacs-devel@gnu.org
>
> "Eli Zaretskii" <eliz@gnu.org> writes:
>
> > The inclusion of igc.h should be conditioned by HAVE_MPS.
>
> Thanks. I think we currently include igc.h unconditionally and igc.h
> should start with #ifdef HAVE_MPS; but I see now that I accidentally
> broke that by making enum igc_obj_type public unconditionally.
>
> Can you clarify whether you prefer to wrap each #include or the entire
> igc.h file in #ifdef HAVE_MPS?
I just did, didn't I? ;-)
next prev parent reply other threads:[~2024-08-05 18:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 15:00 [MPS-test] scratch/igc branch (commit: 42731228d24) crashed Eval Exec
2024-08-05 15:12 ` Gerd Möllmann
2024-08-05 15:18 ` Eval Exec
2024-08-05 15:34 ` Gerd Möllmann
2024-08-05 15:20 ` Eval Exec
2024-08-05 15:45 ` Gerd Möllmann
2024-08-05 15:48 ` Eval Exec
2024-08-05 15:55 ` Eval Exec
2024-08-05 16:14 ` Eval Exec
2024-08-05 15:29 ` Eli Zaretskii
2024-08-05 15:33 ` Eval Exec
2024-08-05 15:47 ` Gerd Möllmann
2024-08-05 15:54 ` Eli Zaretskii
2024-08-05 16:01 ` Gerd Möllmann
2024-08-05 16:20 ` Pip Cet
2024-08-05 16:40 ` Pip Cet
2024-08-05 16:50 ` Eval Exec
2024-08-05 17:45 ` Eli Zaretskii
2024-08-05 18:00 ` Pip Cet
2024-08-05 18:19 ` Eli Zaretskii [this message]
2024-08-08 16:56 ` Eval Exec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86seviq1bs.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=execvy@gmail.com \
--cc=pipcet@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.