From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73801: 31.0.50; project-try-vc sometimes set wrong cache project-vc-extra-root-markers Date: Tue, 29 Oct 2024 15:33:36 +0200 Message-ID: <86sesf58zz.fsf@gnu.org> References: <3b9816c7-bec3-4743-ad1a-49332c158099@gutov.dev> <1a2ab2c3-272a-41c8-af6f-6ed7348189df@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6761"; mail-complaints-to="usenet@ciao.gmane.io" Cc: i@fuzy.me, 73801@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 29 14:35:26 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t5mNZ-0001Y8-KJ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Oct 2024 14:35:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t5mNF-0004VR-0y; Tue, 29 Oct 2024 09:35:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t5mND-0004T0-FB for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2024 09:35:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t5mND-0000no-31 for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2024 09:35:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=SzMSTDVeNA7BvwCrZzUU3X0TOt2QlrQ+3TgYUzdJFIw=; b=ZWI0CNkOC99nAPg9GysC99f2dC2d+Jc+JDVoA9CgOl2Amuwn3Hzz4CelQVuPl9UADs7SzHUfdk8uLCdWNlsVknxTz2IwN4kdbVi7k+K2/j1IQn9ZRRyc9/6FLIIlpR9/PfU8te9I9f3xqVW0jergAb6bfHDO13q8WDmAo/glVCoUOavv5QHm9Ophc462HE1W1mQygrsp/onrxyhw1StLUMOVD7n3hSMTrDt/tr2s4sNawzffR2PewHNpPyN6TXsbZatUkMlubzImWn46q7mK2F1ZevyWX5tc0nF6MlpVg9XDu6GTkDoRKUDKbvxhkc1SSR8zJza+16NLV5U9TofjFQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t5mNB-0004zU-Tb for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2024 09:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Oct 2024 13:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73801 X-GNU-PR-Package: emacs Original-Received: via spool by 73801-submit@debbugs.gnu.org id=B73801.173020887919168 (code B ref 73801); Tue, 29 Oct 2024 13:35:01 +0000 Original-Received: (at 73801) by debbugs.gnu.org; 29 Oct 2024 13:34:39 +0000 Original-Received: from localhost ([127.0.0.1]:56423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5mMp-0004z6-AW for submit@debbugs.gnu.org; Tue, 29 Oct 2024 09:34:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5mMm-0004yw-OA for 73801@debbugs.gnu.org; Tue, 29 Oct 2024 09:34:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t5mMe-0000jX-8n; Tue, 29 Oct 2024 09:34:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=SzMSTDVeNA7BvwCrZzUU3X0TOt2QlrQ+3TgYUzdJFIw=; b=pMC+UyHPXhD5 JLGojQbVdxY+O2/rp7/5ugw4mvvmC4fCn4ABgB7u0GyvxWLGq55g33czkt93ry49xgzl9TzoirbeO +tfLEYcK7CZdIC0fUsASjwH9uEQrSGY8mZmcvY1qFsatGG68+9tbFZh2oGcC2kKexcJsf0C6F5WN5 weB5t7h2SqkpiGy73cVNERH+pIg+rNuy3nJjTPPpio+1KO+qEBecZlKMHPgeGLEK1/ZFBW7KXeoK6 wAVeCm+8UYP9qlWJCwqbO8cq3ItwoH3j4GqB2/WOa2Wg1gkeFUXI8j/kkIogy1D257o1LYYSYd7Do 6TkwFPURJV8RXBOVSzDY3g==; In-Reply-To: <1a2ab2c3-272a-41c8-af6f-6ed7348189df@gutov.dev> (message from Dmitry Gutov on Tue, 29 Oct 2024 04:44:13 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294489 Archived-At: > Date: Tue, 29 Oct 2024 04:44:13 +0200 > From: Dmitry Gutov > Cc: Zhengyi Fu > > Since I see some changes added to the release branch still, > > On 28/10/2024 06:06, Dmitry Gutov wrote: > > It would be nice to get either of the patches into Emacs 30, too, but it > > might be a little late given where it is in the pretest. > > Eli, could we install either of the fixes for this bug to emacs-30 too? > > The one I installed on master is longer but should result in less I/O, > while the patch by Zhengyi Fu is a one-liner, which might feel a little > safer. I don't understand the implications of that one-line (nor, TBH, the analysis of the original problem), so I'm not sure these changes are safe. How do we know that catering to this corner case will not screw other corner cases? It isn't the first time project.el needs to tiptoe between several valid outcomes using some pretty ad-hoc heuristic.