From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74647: 31.0.50; Build failure on master w/ librsvg-2.58.5 Date: Mon, 02 Dec 2024 18:26:16 +0200 Message-ID: <86ser62grb.fsf@gnu.org> References: <87zfle1f6i.fsf@gentoo.org> <867c8i43iz.fsf@gnu.org> <87iks219jf.fsf@gentoo.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40508"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74647-done@debbugs.gnu.org, manuel@ledu-giraud.fr To: Sam James Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 02 17:27:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tI9Gd-000AOn-AO for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Dec 2024 17:27:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tI9GS-0004TF-J9; Mon, 02 Dec 2024 11:27:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tI9GL-0004S6-An for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2024 11:27:06 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tI9GI-00086I-TI for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2024 11:27:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=PxSVAag7xxcRfOMNCTZQOHG5s7WbexBn42BjtJRBXO0=; b=TVsVKawC6fDPpGClyx8TflgEQpLhT6xCOubkgzjWg7soIMBJ22dcYqslydLsxPjct9C0zZ0R0cQiHnLtzJ7MM5BmHq75b7njFtAoSRbEA8Ko3bnJdPAFJtomO5i+KgZ9KtQ45kGb4zx0utfBCMtBlbfvprfBWfnveJqd3NPx43tYoYRhNH7tP1TL/+iE6LnUNepxSFQ7bscOxa+FtrQZcqPDF3l2+6V5fmLmYW+oOTlgasqmFuKaSvkDJ7FbyqLAJc5TAM8GHe9pm+JTftLkjwkDf1j8Cp/1/6KYfHKJKYa29/cHqUNJM8qnHIohYLxkl6wBPthSU0EtRz9XpyGRdg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tI9GI-0001ai-OG for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2024 11:27:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Dec 2024 16:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 74647 X-GNU-PR-Package: emacs Mail-Followup-To: 74647@debbugs.gnu.org, eliz@gnu.org, sam@gentoo.org Original-Received: via spool by 74647-done@debbugs.gnu.org id=D74647.17331567886044 (code D ref 74647); Mon, 02 Dec 2024 16:27:02 +0000 Original-Received: (at 74647-done) by debbugs.gnu.org; 2 Dec 2024 16:26:28 +0000 Original-Received: from localhost ([127.0.0.1]:56280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI9Fj-0001ZQ-I6 for submit@debbugs.gnu.org; Mon, 02 Dec 2024 11:26:27 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI9Fh-0001Z6-7b for 74647-done@debbugs.gnu.org; Mon, 02 Dec 2024 11:26:26 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tI9Fb-0007sH-5R; Mon, 02 Dec 2024 11:26:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=PxSVAag7xxcRfOMNCTZQOHG5s7WbexBn42BjtJRBXO0=; b=q/rT8GagtUXdGivbRJVz aEtVGvsEr6Kv5FHnHIqcaA/6R+nwHdcof5R42yITd6AwLq73TifUxMwKw5A9jAYlI5gwIAz4f1Ofy VLH9DOAd+zCcCi5L0UidFGxDUluO01IVG9ereP1m6lyI9TJMfh3zp2HhZsx/EuuJpHEGjSuLFFatg izHtSm3uJgQmSpZTkH8XwaUV9PpvhRnud2Yp+sL0vcZG0ZeZ2yJQUCR+uqFvFwLpiJKAl3245uF10 9CDCvViC78Ob6lxWyK+Yc0jALEQNTADRcYtFwg74KUTz4ydQpi13DCJL77A4DYGyf3a/EQdENlwfU y8AE22jjcnjwGA==; In-Reply-To: <87iks219jf.fsf@gentoo.org> (message from Sam James on Mon, 02 Dec 2024 13:47:32 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296337 Archived-At: > From: Sam James > Cc: 74647@debbugs.gnu.org, manuel@ledu-giraud.fr > Date: Mon, 02 Dec 2024 13:47:32 +0000 > > Eli Zaretskii writes: > > >> Cc: Manuel Giraud > >> From: Sam James > >> Date: Mon, 02 Dec 2024 11:45:41 +0000 > >> > >> I see the following build failure (with a clean bootstrap) with librsvg-2.58.5 on master: > >> """ > >> image.c: In function ‘svg_load_image’: > >> image.c:12358:12: error: implicit declaration of function ‘rsvg_handle_get_pixbuf_and_error’; did you mean ‘rsvg_handle_get_pixbuf_sub’? [-Wimplicit-function-declaration] > >> 12358 | pixbuf = rsvg_handle_get_pixbuf_and_error (rsvg_handle, &err); > >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >> | rsvg_handle_get_pixbuf_sub > >> image.c:12358:12: warning: nested extern declaration of ‘rsvg_handle_get_pixbuf_and_error’ [-Wnested-externs] > >> image.c:12358:10: error: assignment to ‘GdkPixbuf *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion] > >> 12358 | pixbuf = rsvg_handle_get_pixbuf_and_error (rsvg_handle, &err); > >> | ^ > >> make[2]: *** [Makefile:457: image.o] Error 1 > >> make[2]: *** Waiting for unfinished jobs.... > >> """ > >> > >> I've attached the full build.log. Let me know if you need more information. > > > > Manuel, I guess the version guard needs some adjustment? Which > > version of librsvg introduced rsvg_handle_get_pixbuf_and_error? > > It looks like it was introduced in > https://gitlab.gnome.org/GNOME/librsvg/-/merge_requests/931, > specifically commit 85cdba02a3e126c1099a62b3d6421ac0cb2d790b, which says > "* Deprecated: 2.58.", but that commit doesn't appear in any release of > 2.58, only >=2.58.90 (and so on) which are pre-releases of 2.59. This was fixed on the emacs-30 branch together with bug#74606.