From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74833: 31.0.50; Copy to OS clipboard doesn't work in macOS Terminal.app with xterm-mouse-mode enabled Date: Sat, 04 Jan 2025 15:15:55 +0200 Message-ID: <86sepyd8j8.fsf@gnu.org> References: <8634iszpa5.fsf@gnu.org> <86y10ky9wf.fsf@gnu.org> <86wmg4xd2u.fsf@gnu.org> <86y10jwmsb.fsf@gnu.org> <86ldwiwvjc.fsf@gnu.org> <86ed27pfhj.fsf@gnu.org> <86a5cvpeiv.fsf@gnu.org> <86y10eo5h6.fsf@gnu.org> <986a3eea465e13c57bcdd7ce8f27f99d@finder.org> <864j2w6tz0.fsf@gnu.org> <861pxy5zxk.fsf@gnu.org> <86jzbq4i6x.fsf@gnu.org> <86frme4exq.fsf@gnu.org> <865xn5y2n0.fsf@gnu.org> <5e102d7d29eba618874c0b41e9815b8d@finder.org> <86ldw0ur0h.fsf@gnu.org> <86h66nq7vh.fsf@gnu.org> <83cf221bcf4fc4162c7401b9146d1961@finder.org> <867c7dljph.fsf@gnu.org> <6b8d9d19697dae5f0b4a06920e559dc1@finder.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8432"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, 74833-done@debbugs.gnu.org, fgunbin@fastmail.fm, shipmints@gmail.com, rms@gnu.org To: Jared Finder Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 04 14:17:29 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tU41x-000241-Bb for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Jan 2025 14:17:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tU41f-0006am-Nd; Sat, 04 Jan 2025 08:17:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU41W-0006Z8-Qx for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 08:17:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tU41W-0004sN-II for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 08:17:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=SSzDWxmDrsBvQc4mDGY+8w0oyDIVUgRqqtPMMWGlseY=; b=JwgPEzIXQvHPOdgst8HFGNUDTuwlQWsaDiM0CgxHwTyFiCAF9b4+MkW0BaFDV6zulRW5XQh2yhNq253qpGdg+74p4RNU9JoCv2G07ehkORkgsvGg59ZGTYyaNTFluYTcO+IimF/w6MCyHR+86Zar1p0cpQwAgVIQEzNmrUE/VCRjWAxp1DJQDCJZe+TDz5JsLg9C/gKd2lXp11C2b/2I3hXwxttTWcPjfCzziLB+/p8SVLXAeRuS/R1P3k2J3X6ZLjvn1E6PhHGXOEEkYGSmhXug5A6W03HOrfvirDsQYYvJjUYqeBYCwI7UzM+7NMoa0hlsppeM8/g6llk+pgJngg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tU41W-0007bW-8X for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 08:17:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jan 2025 13:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 74833 X-GNU-PR-Package: emacs Mail-Followup-To: 74833@debbugs.gnu.org, eliz@gnu.org, fgunbin@fastmail.fm Original-Received: via spool by 74833-done@debbugs.gnu.org id=D74833.173599659929183 (code D ref 74833); Sat, 04 Jan 2025 13:17:01 +0000 Original-Received: (at 74833-done) by debbugs.gnu.org; 4 Jan 2025 13:16:39 +0000 Original-Received: from localhost ([127.0.0.1]:53878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU418-0007ad-Nv for submit@debbugs.gnu.org; Sat, 04 Jan 2025 08:16:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41704) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tU413-0007aC-KL for 74833-done@debbugs.gnu.org; Sat, 04 Jan 2025 08:16:37 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU40j-00034A-Lx; Sat, 04 Jan 2025 08:16:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=SSzDWxmDrsBvQc4mDGY+8w0oyDIVUgRqqtPMMWGlseY=; b=dE15Q4fSYKdK JtqDZockX4/Jix0e+aGWvYZQSA+d7lE85l5Jz6RQ8pjfI9943iZgkvEFpxF1to+JwwvDee8YiKicp Va2L+wq+SJpZqeQqJX8TD+wIuPccoa7tA+WMfBvyjMWWrhvpKzXL3gU0NIIm3NyrCnFMkzTM9ZW+h tszCPs+zEPeilr7J5f0aMpwUHUEepSwlmW4Xzyi4ShiqNdqlWFKxIOXoTp6uHvVFjD6oiaZjnzDpI mX366Gs80jgtWQf+Xeu6SCmOga7UUJQ7fcf8i2bXO7U/Ao8rbqvMx8IWHIegIryQYzrJr0EhIa+iG oCisGgRfSUReW8dWf8CM4A==; In-Reply-To: <6b8d9d19697dae5f0b4a06920e559dc1@finder.org> (message from Jared Finder on Thu, 02 Jan 2025 08:55:02 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298395 Archived-At: > Date: Thu, 02 Jan 2025 08:55:02 -0800 > From: Jared Finder > Cc: shipmints@gmail.com, rms@gnu.org, gerd.moellmann@gmail.com, > fgunbin@fastmail.fm, 74833@debbugs.gnu.org > > On 2025-01-02 00:10, Eli Zaretskii wrote: > >> Date: Wed, 01 Jan 2025 23:10:14 -0800 > >> From: Jared Finder > >> Cc: shipmints@gmail.com, rms@gnu.org, gerd.moellmann@gmail.com, > >> fgunbin@fastmail.fm, 74833@debbugs.gnu.org > >> > >> Patch attached. > > > > Thanks. This LGTM, but please modify this comment: > > > >> +(defun xterm--query-name-and-version () > >> + "Get the terminal name and version string (XTVERSION)." > >> + ;; The default timeout time causes a noticeable startup delay on > >> + ;; terminals that ignore the query. > >> + (let ((xterm-query-timeout 0.1)) > > > > to the effect that we use non-default value of 0.1 because the default > > (larger) value causes a noticeable startup delay. It took me a few > > seconds to understand the intent; initially I thought that you were > > describing what happens when 0.1 is used. > > > >> I also noticed outdated text in the docstring for xterm-mouse-mode and > >> attached a second patch to delete that text. > >> [...] > >> -Turn it on to use Emacs mouse commands, and off to use xterm mouse > >> commands. > >> -This works in terminal emulators compatible with xterm. It only > >> -works for simple uses of the mouse. Basically, only non-modified > >> -single clicks are supported. When turned on, the normal xterm > >> -mouse functionality for such clicks is still available by holding > >> -down the SHIFT key while pressing the mouse button." > >> +Turn it on to use Emacs mouse commands, and off to use xterm mouse > >> +commands. This works in terminal emulators compatible with xterm. > >> When > >> +turned on, the normal xterm mouse functionality for such clicks is > >> still > >> +available by holding down the SHIFT key while pressing the mouse > >> button." > > > > This is also okay, but please add to the doc strings a reference to > > sterm--init where we verify that the terminal is compatible with > > xterm-mouse-mode. > > Comments addressed. I've collapsed both patches down to one (it was > easier for me). Thanks, installed on master, and closing the bug.