all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Re: master 40e38a681da: ; * test/src/editfns-tests.el (editfns-tests-styled-print): New test.
       [not found] ` <20250204121905.793ABC37C82@vcs2.savannah.gnu.org>
@ 2025-02-04 12:28   ` Pip Cet via Emacs development discussions.
  2025-02-04 14:42     ` Eli Zaretskii
  0 siblings, 1 reply; 2+ messages in thread
From: Pip Cet via Emacs development discussions. @ 2025-02-04 12:28 UTC (permalink / raw)
  To: emacs-devel; +Cc: Eli Zaretskii

"Eli Zaretskii" <eliz@gnu.org> writes:

> branch: master
> commit 40e38a681dafb02f71d741338e9c3c5ff99c734e
> Author: Eli Zaretskii <eliz@gnu.org>
> Commit: Eli Zaretskii <eliz@gnu.org>
>
>     ; * test/src/editfns-tests.el (editfns-tests-styled-print): New test.

Thanks for installing this test (from
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75754#14, with
modifications).  It passes here.

Just as a heads-up: this test shouldn't crash current Emacs versions,
but will crash other recent Emacs versions, so if anyone's running
non-current Emacs versions on the current test suite, be prepared for
crashes :-)

> diff --git a/test/src/editfns-tests.el b/test/src/editfns-tests.el
> index 9fff4255b57..b18111ad119 100644
> --- a/test/src/editfns-tests.el
> +++ b/test/src/editfns-tests.el
> @@ -534,4 +534,15 @@
>                              'utf-8 nil (current-buffer))
>        (should (null (sanity-check-change-functions-errors))))))
>
> +(ert-deftest editfns-tests-styled-print ()
> +  "Test bug#75754."
> +  :expected-result :failed

... so why is it expected to fail?

> +   (let* ((print-unreadable-function
> +          (lambda (&rest _args)
> +             (garbage-collect)
> +             (make-string 100 ?Ā t)))
> +          (str "\"[1] ĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀĀ\""))
> +     (should (string= (format "%S" (format "%S %S" [1] (symbol-function '+)))
> +                      str))))
> +
>  ;;; editfns-tests.el ends here

Pip




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: master 40e38a681da: ; * test/src/editfns-tests.el (editfns-tests-styled-print): New test.
  2025-02-04 12:28   ` master 40e38a681da: ; * test/src/editfns-tests.el (editfns-tests-styled-print): New test Pip Cet via Emacs development discussions.
@ 2025-02-04 14:42     ` Eli Zaretskii
  0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2025-02-04 14:42 UTC (permalink / raw)
  To: Pip Cet; +Cc: emacs-devel

> Date: Tue, 04 Feb 2025 12:28:16 +0000
> From: Pip Cet <pipcet@protonmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>
> 
> > +  :expected-result :failed
> 
> ... so why is it expected to fail?

Because I forgot to remove that, sorry.  Fixed in a followup commit.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-02-04 14:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <173867154507.31295.6305678790068977365@vcs2.savannah.gnu.org>
     [not found] ` <20250204121905.793ABC37C82@vcs2.savannah.gnu.org>
2025-02-04 12:28   ` master 40e38a681da: ; * test/src/editfns-tests.el (editfns-tests-styled-print): New test Pip Cet via Emacs development discussions.
2025-02-04 14:42     ` Eli Zaretskii

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.