browse-url-mozilla fails if new-window is nil

browse-url-mozilla fails if new-window is nil

[Davide G.M.Salvetti]

[-- Attachment #1: Type: text/plain, Size: 2814 bytes --]

This bug report will be sent to the Free Software Foundation,
not to your local site managers!
Please write in English, because the Emacs maintainers do not have
translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
and to the gnu.emacs.bug news group.

In GNU Emacs 21.2.1 (i386-debian-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2002-03-22 on raven, modified by Debian
configured using `configure  i386-debian-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --with-pop=yes --with-x=yes --with-x-toolkit=athena --without-gif'
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

The bug gets triggered with
"M-x browse-url-mozilla RET http://www.gnu.org/ RET"
(browse-url-new-window-flag's value is nil).

Having set debug-on-error, I get:
<======================================================================>
Debugger entered--Lisp error: (wrong-type-argument stringp nil)
  start-process("mozilla http://www.gnu.org/" nil "mozilla" "-remote" "openurl(" "http://www.gnu.org/" nil ")")
  apply(start-process "mozilla http://www.gnu.org/" nil "mozilla" ("-remote" "openurl(" "http://www.gnu.org/" nil ")"))
  (let* ((process-environment ...) (process ...)) (set-process-sentinel process (\` ...)))
  browse-url-mozilla("http://www.gnu.org/" nil)
* call-interactively(browse-url-mozilla)
  execute-extended-command(nil)
  call-interactively(execute-extended-command)
<======================================================================>

I think the one-line attached patch fixes the problem.

Recent input:
C-SPC C-SPC C-SPC C-SPC C-SPC C-SPC C-SPC C-SPC C-SPC 
C-SPC C-SPC C-SPC C-SPC C-SPC C-SPC C-SPC C-SPC C-SPC 
C-SPC C-SPC C-SPC C-SPC C-SPC C-SPC C-SPC C-SPC C-SPC 
C-SPC C-SPC C-SPC C-SPC C-SPC C-SPC C-SPC C-SPC C-SPC 
C-SPC C-SPC C-SPC C-SPC C-SPC C-SPC C-SPC C-SPC C-SPC 
C-SPC C-SPC C-SPC C-SPC C-SPC M-x b r o <tab> - m o 
z i <tab> <return> h t t p : / / w w w . g n u . o 
r g / <return> C-p C-SPC M-> M-w q M-x e <backspace> 
r e p o r <tab> e m <tab> <return>

Recent messages:
Entering debugger...
 [2 times]
Back to top level.
Type C-x 4 b RET to restore the other window.  C-M-v to scroll the help.
Mark set [410 times]
apply: 
Entering debugger...
 [2 times]
Mark set [2 times]
Back to top level.

-- 
Salve, | GNU PG (GPG) Key ID: 9396865D
Davide | <http://www.linux.it/~salve/>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: browse-url.el.patch --]
[-- Type: text/x-patch, Size: 535 bytes --]

*** /usr/share/emacs/21.2/lisp/net/browse-url.el	Tue Dec  4 19:12:05 2001
--- /tmp/browse-url.el.new	Mon Sep 16 20:24:22 2002
***************
*** 852,858 ****
  			  (list "-remote")
  			  (list "openurl("
  				url
! 				(if new-window ",new-window")
  				")")))))
      (set-process-sentinel process
  			  `(lambda (process change)
--- 852,858 ----
  			  (list "-remote")
  			  (list "openurl("
  				url
! 				(if new-window ",new-window" "")
  				")")))))
      (set-process-sentinel process
  			  `(lambda (process change)