From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: merlyn@stonehenge.com (Randal L. Schwartz) Newsgroups: gmane.emacs.devel Subject: Re: git transition issues Date: Tue, 28 Oct 2014 14:16:57 -0700 Organization: Stonehenge Consulting Services; Portland, Oregon, USA Message-ID: <86r3xrnbcm.fsf@red.stonehenge.com> References: <20141027000718.F09B5382A66@snark.thyrsus.com> <544DA310.1090902@porkrind.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1414531061 473 80.91.229.3 (28 Oct 2014 21:17:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 28 Oct 2014 21:17:41 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 28 22:17:36 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XjE90-00071I-OC for ged-emacs-devel@m.gmane.org; Tue, 28 Oct 2014 22:17:34 +0100 Original-Received: from localhost ([::1]:41466 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjE90-0000hf-8k for ged-emacs-devel@m.gmane.org; Tue, 28 Oct 2014 17:17:34 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57906) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjE8i-0000hR-Bm for emacs-devel@gnu.org; Tue, 28 Oct 2014 17:17:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XjE8a-0001kW-HY for emacs-devel@gnu.org; Tue, 28 Oct 2014 17:17:16 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:53092) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjE8a-0001hR-Ad for emacs-devel@gnu.org; Tue, 28 Oct 2014 17:17:08 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XjE8Z-0006eI-3B for emacs-devel@gnu.org; Tue, 28 Oct 2014 22:17:07 +0100 Original-Received: from red.stonehenge.com ([208.79.95.2]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 28 Oct 2014 22:17:07 +0100 Original-Received: from merlyn by red.stonehenge.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 28 Oct 2014 22:17:07 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 29 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: red.stonehenge.com x-mayan-date: Long count = 13.0.1.15.16; tzolkin = 4 Cib; haab = 9 Zac User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (berkeley-unix) Cancel-Lock: sha1:e0tvSIA9fO3wLKWQiJIT/5hpRKQ= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:175943 Archived-At: >>>>> "David" == David Caldwell writes: David> On 10/26/14 5:07 PM, esr@thyrsus.com (Eric S. Raymond) wrote: >> lisp/version.el: The bzr-specific code for version extraction will be >> obsolete. The git-specific code is very broken. Among other >> problems, in my stock Ubuntu environment the git log command it >> generates always fails, apparently because it can't find terminal >> capabilities it wants. David> From version.el: David> (call-process "git" nil '(t nil) nil "log" David> "-1" "--pretty=format:%N") David> This looks wrong to me. %N is the commit's note from "git notes". David> Perhaps this should be %H, to get the commit hash? And if so, I think David> the better way is with "git show-ref", as it's a plumbing command where David> "git log" is not (git log likes to redirect stuff through your $PAGER, etc). David> git show-ref -s --head ^HEAD Consider instead something like "git describe --tags HEAD", which generates a fairly short yet meaningful and distinct value regardless of where HEAD is. -- Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095 Perl/Unix consulting, Technical writing, Comedy, etc. etc. Still trying to think of something clever for the fourth line of this .sig