From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Joseph Mingrone Newsgroups: gmane.emacs.devel Subject: Re: master fails to build on FreeBSD when ACL support is on Date: Fri, 19 Jan 2018 10:59:16 -0400 Message-ID: <86r2ql28u3.fsf@phe.ftfl.ca> References: <86o9lua0yx.fsf@phe.ftfl.ca> <834lnly8ht.fsf@gnu.org> <86vafy20sj.fsf@phe.ftfl.ca> <83o9lpuct5.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Trace: blaine.gmane.org 1516374209 31381 195.159.176.226 (19 Jan 2018 15:03:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 19 Jan 2018 15:03:29 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (berkeley-unix) Cc: eggert@cs.ucla.edu, ashish@FreeBSD.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 19 16:03:25 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecYCC-0006yw-K8 for ged-emacs-devel@m.gmane.org; Fri, 19 Jan 2018 16:03:08 +0100 Original-Received: from localhost ([::1]:54164 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecYEC-0008Qq-Gp for ged-emacs-devel@m.gmane.org; Fri, 19 Jan 2018 10:05:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecY8Y-0003mM-Sf for emacs-devel@gnu.org; Fri, 19 Jan 2018 09:59:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecY8V-0004MY-Oq for emacs-devel@gnu.org; Fri, 19 Jan 2018 09:59:23 -0500 Original-Received: from mail-qt0-f182.google.com ([209.85.216.182]:36605) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ecY8V-0004Lq-K8 for emacs-devel@gnu.org; Fri, 19 Jan 2018 09:59:19 -0500 Original-Received: by mail-qt0-f182.google.com with SMTP id z11so4421939qtm.3 for ; Fri, 19 Jan 2018 06:59:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=3PWhqs6mOx2Tkpq2wyi8WLA4qLwNgOxnDp73Qb+d/yI=; b=kuy3K+nne3Fzq24OBE38msoabj5mzlPncsPsps8a2+gfrA7m6JQY9GdvhTnFxcDiFF 0EOiRUC9xgSioAKJw28KBtN07bm1pS10K2/kU3Ho7LjidJT71x7Hkhmb9ECzgT9ZB4IG +quwu6UiGJyTVv+xfNLHIsn8WbVaDLmnECCPRymVlMkIWMy/7da5kn0pAgctJDFgj5Hf 4a0FO4MfaXotITVFUPFDZ72NsTySlu3SjS/nqYQbEMnLtZJVBOIoBTRL0bhgBfx24Ypm YKG+9XydvnkWcKcvbZbeMA11jwjkUYqf+6FHoxhq2+mxUugdJxE+jicf0RX4H+mqXIoj NLnA== X-Gm-Message-State: AKwxyteQdI74k8aZSCZYav57sK0HIfDh0JyzEhn38k7OAoZuAEd+anSG 7MRQY7T5hFy7Qqiw62wnjHx5Rw== X-Google-Smtp-Source: ACJfBouxEyjF1s+X3TsF3jWza/AJUyDPz3ScMqMqWlnU44wbVlVD20wbWesLJ5Sz/kyhXRgAIEFPgA== X-Received: by 10.233.244.1 with SMTP id y1mr44737829qkl.308.1516373958878; Fri, 19 Jan 2018 06:59:18 -0800 (PST) Original-Received: from phe.ftfl.ca.ftfl.ca (hlfxns017vw-47-55-140-73.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.140.73]) by smtp.gmail.com with ESMTPSA id x207sm176347qka.91.2018.01.19.06.59.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 19 Jan 2018 06:59:17 -0800 (PST) In-Reply-To: <83o9lpuct5.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 19 Jan 2018 16:45:58 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.216.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222087 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Joseph Mingrone >> Cc: emacs-devel@gnu.org, Paul Eggert , ashish@FreeBSD.org >> Date: Thu, 18 Jan 2018 19:40:44 -0400 >> The same error occurs with bf9b972 from December 2, but only when ACL is >> on. By moving back one commit to ac144dc, the build succeeds regardless >> of the status of ACL. >> With commit bf9b972 the value of tempfile looks something like this. >> /tmp/autoload.elca4aVmU >> With that commit reverted, the value of tempfile looks something like this. >> /wrkdirs/usr/ports/editors/emacs-devel/work-full/emacs-694ee38/lisp/emacs-lisp/autoload.elcFmWzli >> Inside the builder jail, the /tmp permissions are drwxrwxrwt. >> Using the latest commit, but with the change in bf9b972 reverted, the >> build succeeds. > Thanks. Does the patch below solve the problem? > diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el > index acba9e2..a0ab14f 100644 > --- a/lisp/emacs-lisp/bytecomp.el > +++ b/lisp/emacs-lisp/bytecomp.el > @@ -1933,7 +1933,17 @@ byte-compile-file > ;; parallel bootstrap), it does not risk getting a > ;; half-finished file. (Bug#4196) > (tempfile > - (make-temp-file (file-name-nondirectory target-file))) > + ;; If target-file is relative and includes > + ;; leading directories, make-temp-file will > + ;; assume those leading directories exist > + ;; under temporary-file-directory, which might > + ;; not be true. So strip leading directories > + ;; from relative file names before calling > + ;; make-temp-file. > + (if (file-name-absolute-p target-file) > + (make-temp-file target-file) > + (make-temp-file > + (file-name-nondirectory target-file)))) > (default-modes (default-file-modes)) > (temp-modes (logand default-modes #o600)) > (desired-modes (logand default-modes #o666)) It does. Thank you. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEVbCTpybDiFVxIrrVNqQMg7DW754FAlpiB8RfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU1 QjA5M0E3MjZDMzg4NTU3MTIyQkFENTM2QTQwQzgzQjBENkVGOUUACgkQNqQMg7DW 757dzw/9ElYG2+FKHD07k8yIisDyziHN1cNSY1wNlDqxakzvToJSJSjiUIArQZrh Rccb9FFhZBOrwzJ4BViP20chMhMvgENWmhzDRzNBOn72LMxRpg3vAKWYoADn/sv2 n/XmnHdaGaeXPzwQRp7gzxxuJCCl3KNSMpOGKY11VvH6qMHzxxjuIjAhvEJg+g1E MYr4fCUuhk4ucRaiShUKKhdx+hJZunhDHKSMc8Fgd1hoaIFZvwcqqn8EMHosCqVQ mKfGOWbYkA1ZQyhikMBIJvukLTqwxniq1hxHAn2wdP91BiSHr2VHNvmau04tCCoj 23lhl22PgntORby+A6Liose0tk4Fexbb+F47T7tWup4oA1MdNSmndvsP88DqTBxP N0hUA8PngwGWeMsCrVNX2iuawciy04Rctv8JMKBBe1Uef5PxhIvosASbnUI/tfmV isBlVlnqD3Bqerwbl3PA08ZVWECoXPgy1yYNMR+rNwXqwXghJjGOargMR1UO5C22 NWQtUWHSpxYcYuCUydco/dIz6FkwtNB41kfdlh6mDjwf4JEpOb4mvqtRTbUKH65i FC6MSFf91X/sM75PlfgGRDYY2nJayhm8sPHX9wwVZt+uUERGqH90u1erRZMFr8lw nhdC4N/31+8tNLvSB/7rQFhutvB+7XDo7bdx1GWaWwddGKgPhJ4= =FfaC -----END PGP SIGNATURE----- --=-=-=--