From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#51497: 29.0.50; (vc-print-log) broken over TRAMP Date: Sat, 06 Nov 2021 22:11:03 +0000 Message-ID: <86r1btvsso.fsf@gmail.com> References: <877ddv9ue0.fsf@jpl.nasa.gov> <87tugyptju.fsf@gnus.org> <87tugy8h3a.fsf@secretsauce.net> <87pmrl8yhy.fsf@secretsauce.net> <60fea707-a9b2-d9f4-cc45-ffd4539887b6@yandex.ru> <87o87253sv.fsf@secretsauce.net> <60af7952-d702-d40f-928e-1320e6d9520f@yandex.ru> <83f40a2a-ae5a-2c6c-cf6a-44ff7c933d16@yandex.ru> <831r3tb7un.fsf@gnu.org> <7e04f090-81de-d5bd-746c-7f09ed0c38b0@yandex.ru> <83lf219i3u.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11988"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (windows-nt) To: 51497@debbugs.gnu.org Cancel-Lock: sha1:orurG+XRsTmCfxS39Z7BWsnCi8E= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 06 23:12:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjTv1-0002vs-7N for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Nov 2021 23:12:11 +0100 Original-Received: from localhost ([::1]:38734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjTuz-0000pX-4q for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Nov 2021 18:12:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjTus-0000pN-HM for bug-gnu-emacs@gnu.org; Sat, 06 Nov 2021 18:12:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39432) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjTus-000354-8P for bug-gnu-emacs@gnu.org; Sat, 06 Nov 2021 18:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mjTur-0002Tt-UJ for bug-gnu-emacs@gnu.org; Sat, 06 Nov 2021 18:12:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <877ddv9ue0.fsf@jpl.nasa.gov> Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Nov 2021 22:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51497 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16362366839490 (code B ref -1); Sat, 06 Nov 2021 22:12:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Nov 2021 22:11:23 +0000 Original-Received: from localhost ([127.0.0.1]:50978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjTuB-0002Su-5C for submit@debbugs.gnu.org; Sat, 06 Nov 2021 18:11:23 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:40390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjTu7-0002Sh-24 for submit@debbugs.gnu.org; Sat, 06 Nov 2021 18:11:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjTu6-0000nA-Nf for bug-gnu-emacs@gnu.org; Sat, 06 Nov 2021 18:11:14 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:32912) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjTu4-0002MM-Kg for bug-gnu-emacs@gnu.org; Sat, 06 Nov 2021 18:11:14 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mjTu2-0001p0-AZ for bug-gnu-emacs@gnu.org; Sat, 06 Nov 2021 23:11:10 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 15 X-Spam_score: 1.5 X-Spam_bar: + X-Spam_report: (1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219166 Archived-At: On Sat 06 Nov 2021, Eli Zaretskii wrote: >> Cc: lists@dima.secretsauce.net, 51497@debbugs.gnu.org, larsi@gnus.org, >> wolfgang.scherer@gmx.de >> From: Dmitry Gutov >> Date: Sat, 6 Nov 2021 22:44:55 +0300 >> >> > I'm a bit worried by the function relying on the fact that >> > default-directory is the directory of the repository. Wouldn't it be >> > better to explicitly let-bind it inside the function? >> >> We could, but notice how most of vc-git-* functions don't bind >> default-directory, thus relying on its implicit value. It just how VC >> works: expecting default-directory to have the right value around the calls. > > How certain are you that default-directory has the right value? > Because if it doesn't, AFAIU all the connection-specific stuff will > fall apart. > >> > A (perhaps safer) alternative for emacs-28 would be not to use >> > :(literal) for remote repositories. What are the disadvantages of >> > that? >> >> That would mean leaving bug#39452 unfixed on remote hosts. > > Only for files with wildcard characters in their names. How > frequently does that happen? Also, it will be only unsolved in Emacs > 28. I missed the discussion in bug#39452 at the time, but while the solution was being worked on, I used advice to stub out the literal pathspec functions: (advice-add 'vc-git--literal-pathspec :override #'identity) (advice-add 'vc-git--literal-pathspecs :override #'identity) That workaround is still needed for me. Without that, nothing in vc-git works in my environment (64bit minw64 build on win10, using cygwin bash and git together with cygwin-mount.el from emacs wiki). While I realise my setup is somewhat non-standard, other users may also find that the literal pathspec code also misbehaves. AndyM