From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#49534: [External] : Re: bug#49534: 26.3; Isearch should support using filter predicates with empty search hits Date: Wed, 16 Feb 2022 21:25:53 +0200 Organization: LINKOV.NET Message-ID: <86r182vcji.fsf@mail.linkov.net> References: <86ee432hgf.fsf@mail.linkov.net> <86sfsiwrvy.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26195"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: "49534@debbugs.gnu.org" <49534@debbugs.gnu.org> To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 16 20:28:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKPyE-0006hH-5u for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Feb 2022 20:28:10 +0100 Original-Received: from localhost ([::1]:54744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nKPyC-0004am-Ek for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Feb 2022 14:28:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52646) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKPy6-0004ae-38 for bug-gnu-emacs@gnu.org; Wed, 16 Feb 2022 14:28:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55611) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nKPy5-0003FC-Py for bug-gnu-emacs@gnu.org; Wed, 16 Feb 2022 14:28:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nKPy5-0007BW-JM for bug-gnu-emacs@gnu.org; Wed, 16 Feb 2022 14:28:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Feb 2022 19:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 49534-submit@debbugs.gnu.org id=B49534.164503967027599 (code B ref 49534); Wed, 16 Feb 2022 19:28:01 +0000 Original-Received: (at 49534) by debbugs.gnu.org; 16 Feb 2022 19:27:50 +0000 Original-Received: from localhost ([127.0.0.1]:49508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKPxu-0007B5-5G for submit@debbugs.gnu.org; Wed, 16 Feb 2022 14:27:50 -0500 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:41995) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKPxs-0007Ao-79 for 49534@debbugs.gnu.org; Wed, 16 Feb 2022 14:27:49 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id CDB86FF803; Wed, 16 Feb 2022 19:27:40 +0000 (UTC) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227056 Archived-At: >> > I'm in no way arguing that your fix is in some >> > way incorrect or insufficient. I'm just trying >> > to understand the code here. I'd appreciate this; thx. >> >> If I designed a new function from scratch then I could explain all >> decisions made while implementing it. But I only fixed a few places >> in the existing function just to pass test cases that you reported. > > Understood. But you must at least understand why > you made the changes you made. That's what I'm > asking about - those particular changes. I made these changes because you reported a bug and provided test cases. So these changes correspond to your test cases one to one.