From: Juri Linkov <juri@linkov.net>
To: Drew Adams <drew.adams@oracle.com>
Cc: "49534@debbugs.gnu.org" <49534@debbugs.gnu.org>
Subject: bug#49534: [External] : Re: bug#49534: 26.3; Isearch should support using filter predicates with empty search hits
Date: Wed, 16 Feb 2022 21:25:53 +0200 [thread overview]
Message-ID: <86r182vcji.fsf@mail.linkov.net> (raw)
In-Reply-To: <SJ0PR10MB5488D606F5F4E9EACB351B5BF3159@SJ0PR10MB5488.namprd10.prod.outlook.com>
>> > I'm in no way arguing that your fix is in some
>> > way incorrect or insufficient. I'm just trying
>> > to understand the code here. I'd appreciate this; thx.
>>
>> If I designed a new function from scratch then I could explain all
>> decisions made while implementing it. But I only fixed a few places
>> in the existing function just to pass test cases that you reported.
>
> Understood. But you must at least understand why
> you made the changes you made. That's what I'm
> asking about - those particular changes.
I made these changes because you reported a bug
and provided test cases. So these changes correspond
to your test cases one to one.
prev parent reply other threads:[~2022-02-16 19:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 14:34 bug#49534: 26.3; Isearch should support using filter predicates with empty search hits Drew Adams
2021-07-13 16:27 ` Lars Ingebrigtsen
2021-07-13 19:25 ` Juri Linkov
2021-07-13 20:20 ` Juri Linkov
2021-07-13 20:41 ` Lars Ingebrigtsen
2021-07-13 22:30 ` Juri Linkov
2021-07-13 21:42 ` bug#49534: [External] : " Drew Adams
2021-07-13 22:30 ` Juri Linkov
2021-07-13 23:00 ` Drew Adams
2021-07-13 22:48 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-13 23:21 ` Juri Linkov
2021-07-13 21:44 ` bug#49534: [External] : " Drew Adams
2021-07-13 22:31 ` Juri Linkov
2021-07-13 23:04 ` Drew Adams
2022-02-16 4:20 ` Drew Adams
2022-02-16 18:20 ` Juri Linkov
2022-02-16 18:54 ` bug#49534: [External] : " Drew Adams
2022-02-16 19:09 ` Juri Linkov
2022-02-16 19:17 ` Drew Adams
2022-02-16 19:25 ` Juri Linkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86r182vcji.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=49534@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.