From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#58447: [PATCH] In project-find-file, add absolute file name to history Date: Thu, 15 Dec 2022 19:21:14 +0200 Organization: LINKOV.NET Message-ID: <86r0x0acnh.fsf@mail.linkov.net> References: <8735budxiz.fsf@gmail.com> <86tu3mftm0.fsf@mail.linkov.net> <875yg0to11.fsf@gmail.com> <86zgdalj0h.fsf@mail.linkov.net> <86fsdpjasd.fsf@mail.linkov.net> <86k02zjiwj.fsf@mail.linkov.net> <864ju1lt5k.fsf@mail.linkov.net> <403e8284-e32c-f547-748e-371d26eedace@yandex.ru> <86cz8or02n.fsf@mail.linkov.net> <87sfhko3tf.fsf@gmail.com> <868rjbusog.fsf@mail.linkov.net> <87h6xylyox.fsf@gmail.com> <1d03758e-369a-c522-a91a-696243f1074f@yandex.ru> <87cz8ln5lt.fsf@gmail.com> <87359hlycd.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34261"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Eli Zaretskii , Augusto Stoffel , 58447@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 15 18:41:33 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5sEe-0008m4-2Y for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Dec 2022 18:41:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5sDH-0008DZ-WB; Thu, 15 Dec 2022 12:40:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5sDE-00089Y-2W for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 12:40:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5sDD-00007o-QQ for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 12:40:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p5sDD-000311-MP for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 12:40:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Dec 2022 17:40:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58447 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58447-submit@debbugs.gnu.org id=B58447.167112598211516 (code B ref 58447); Thu, 15 Dec 2022 17:40:03 +0000 Original-Received: (at 58447) by debbugs.gnu.org; 15 Dec 2022 17:39:42 +0000 Original-Received: from localhost ([127.0.0.1]:43941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5sCr-0002zf-Lh for submit@debbugs.gnu.org; Thu, 15 Dec 2022 12:39:41 -0500 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:45511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5sCq-0002zK-Nj for 58447@debbugs.gnu.org; Thu, 15 Dec 2022 12:39:41 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 5DF4C1C0007; Thu, 15 Dec 2022 17:39:30 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Thu, 15 Dec 2022 16:08:04 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251127 Archived-At: >> In fact I think v2 already is a completely satisfactory implementation >> the project-local file history feature. > > It seems like there are two incompatible behaviors here and you and Juri > want. One is to filter by current project, and another to be able to reuse > previous inputs freely. > > If forced to choose, I would be slightly inclined toward the latter (which > could be implemented using text properties, although the concept is > a little awkward). But both are reasonable. > > I think we should install one of them and then later (on master) add a user > option to switch to the other behavior. I agree with Augusto that filtering that implements project-local history should be the default behavior for emacs-29. I tried your second patch and it nicely handles even such sequences as `C-x p f' and `C-x p F'. (and in the opposite direction from `C-x p F' to `C-x p f' it filters out external files, that is expected and consistent.) OTOH, `C-x p f M-p' in another project is not my primary workflow. But if someone wants to keep a plain history, this could be added later in master, e.g. by a new value of project-read-file-name-function and a function that is mostly a copy of project--read-file-cpd-relative. BTW, in a fresh emacs -Q `C-x p f' raises: Debugger entered--Lisp error: (void-function cl-find-if) But not sure how important is this case since usually `C-x p f' is invoked on a project's file when project.el with cl is loaded.