From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68781: [PATCH] Don't fill yaml except comments and block scalars. Date: Thu, 01 Feb 2024 12:31:30 +0200 Message-ID: <86r0hwzda5.fsf@gnu.org> References: <216ddb7b-e02d-4e68-9dbb-68fa1202d198@mgmarlow.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17816"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68781-done@debbugs.gnu.org, rudi@constantly.at, graham@mgmarlow.com To: Randy Taylor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 01 11:32:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rVUMc-0004S4-Kz for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Feb 2024 11:32:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rVUMM-0003EN-R3; Thu, 01 Feb 2024 05:31:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVUMK-0003AQ-Mm for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2024 05:31:52 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rVUMK-0004U9-E0 for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2024 05:31:52 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rVUMU-0000Ml-Dt for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2024 05:32:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Feb 2024 10:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 68781 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 68781@debbugs.gnu.org, eliz@gnu.org, rudi@constantly.at Original-Received: via spool by 68781-done@debbugs.gnu.org id=D68781.17067835131387 (code D ref 68781); Thu, 01 Feb 2024 10:32:02 +0000 Original-Received: (at 68781-done) by debbugs.gnu.org; 1 Feb 2024 10:31:53 +0000 Original-Received: from localhost ([127.0.0.1]:40312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVUML-0000MI-17 for submit@debbugs.gnu.org; Thu, 01 Feb 2024 05:31:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49272) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVUMI-0000M5-SO for 68781-done@debbugs.gnu.org; Thu, 01 Feb 2024 05:31:51 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVUM2-0004HF-HH; Thu, 01 Feb 2024 05:31:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yl3mbqU5FF8Z0KhDpWAPJfsb+SXwA82hjwte101uyng=; b=It7cjTwllPuE 61wixk8w1ktnXMxHLb4HVDTJQ0/6Ths0x4UsDllltk65+iKKAykkIFao8GGU/ePBnlGecG+kASUje bqdLGBLTLwkkD+p+K1sA7Jn45WMgylkoGJhF2KiLQBk184076jTsXCAem9IEg5V/ZHs72BKZbQZao Dp3u8Q3oK03QdDBSwPlnKC/8qBvdV4Lo30O+Hi3cG+UMomRHlI3PuYMT3gVMEcZZ2yNQO99AF0ql2 dnBZCwT+xaLFmyrEojg9x6R5kf7ssu9kRU08NkoHyLcA732PkBd9rPxuizBTuSy9n0IQVRwXBV6yj 4bp8k2Xs5CyrMisAiaVGqA==; In-Reply-To: (message from Randy Taylor on Tue, 30 Jan 2024 19:25:07 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279279 Archived-At: > Cc: Rudolf Schlatte , 68781@debbugs.gnu.org > Date: Tue, 30 Jan 2024 19:25:07 +0000 > From: Randy Taylor > > On Monday, January 29th, 2024 at 20:20, Graham Marlow wrote: > > > > > > > Hello Randy, thanks for having a look! Could you tell me which > > > > > tree-sitter grammar you are using? I'm asking because with the grammar > > > from https://github.com/ikatyang/tree-sitter-yaml I don't see what you > > > describe. > > > > > > For the record I'm also using this grammar. > > > > Looking at the patch, what do you think about retaining the existing > > behavior (so block_scalars still fill correctly) while inhibiting > > fill_paragraph for everything else as suggested? Originally I retained > > the existing behavior of fill-paragraph just to limit the number of > > things changed by the patch, not because it was working properly. I > > think blocking the call to fill-paragraph for non-block/comment nodes > > makes sense. > > > > I attached a patch w/ my edits, but it just swaps the when to and if, > > accepts the comment node type for filling, and returns t to avoid > > calling fill-paragraph for other nodes. > > Thanks Graham, the patch looks good to me. > > Would someone please install it on master? Thanks in advance. Thanks, done, and closing the bug.